2012-06-23 06:10:52

by Chad Williamson

[permalink] [raw]
Subject: [PATCH] Block: blk-cgroup: fixed compiler warning about unused local variable

Removed an unnecessary local variable in blkg_destroy() which was
causing a compiler warning.

Signed-off-by: Chad Williamson <[email protected]>
---
block/blk-cgroup.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 02cf633..14bd85c 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -245,10 +245,9 @@ EXPORT_SYMBOL_GPL(blkg_lookup_create);

static void blkg_destroy(struct blkcg_gq *blkg)
{
- struct request_queue *q = blkg->q;
struct blkcg *blkcg = blkg->blkcg;

- lockdep_assert_held(q->queue_lock);
+ lockdep_assert_held(blkg->q->queue_lock);
lockdep_assert_held(&blkcg->lock);

/* Something wrong if we are trying to remove same group twice */
--
1.7.7


2012-06-23 07:51:20

by Chad Williamson

[permalink] [raw]
Subject: Re: [PATCH] Block: blk-cgroup: fixed compiler warning about unused local variable

Apologies; this is already fixed in linux-next.

Chad