2022-06-08 11:06:59

by Tomer Maimon

[permalink] [raw]
Subject: [PATCH v2 05/20] watchdog: npcm_wdt: Add NPCM845 watchdog support

Add Nuvoton BMC NPCM845 watchdog support.
The NPCM845 uses the same watchdog as the NPCM750.

Signed-off-by: Tomer Maimon <[email protected]>
---
drivers/watchdog/npcm_wdt.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c
index 28a24caa2627..0b91a3fbec09 100644
--- a/drivers/watchdog/npcm_wdt.c
+++ b/drivers/watchdog/npcm_wdt.c
@@ -231,6 +231,7 @@ static int npcm_wdt_probe(struct platform_device *pdev)
static const struct of_device_id npcm_wdt_match[] = {
{.compatible = "nuvoton,wpcm450-wdt"},
{.compatible = "nuvoton,npcm750-wdt"},
+ {.compatible = "nuvoton,npcm845-wdt"},
{},
};
MODULE_DEVICE_TABLE(of, npcm_wdt_match);
--
2.33.0


2022-06-08 13:34:18

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v2 05/20] watchdog: npcm_wdt: Add NPCM845 watchdog support

On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <[email protected]> wrote:
>
> Add Nuvoton BMC NPCM845 watchdog support.
> The NPCM845 uses the same watchdog as the NPCM750.
>
> Signed-off-by: Tomer Maimon <[email protected]>

This one should no longer be needed if the timers are compatible with the
old ones and correctly described in the DT.

Arnd

2022-06-16 21:29:27

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v2 05/20] watchdog: npcm_wdt: Add NPCM845 watchdog support

On Thu, Jun 16, 2022 at 11:06 PM Tomer Maimon <[email protected]> wrote:
> On Wed, 8 Jun 2022 at 16:05, Arnd Bergmann <[email protected]> wrote:
> >
> > On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <[email protected]> wrote:
> > >
> > > Add Nuvoton BMC NPCM845 watchdog support.
> > > The NPCM845 uses the same watchdog as the NPCM750.
> > >
> > > Signed-off-by: Tomer Maimon <[email protected]>
> >
> > This one should no longer be needed if the timers are compatible with the
> > old ones and correctly described in the DT.
> by timers do you mean clocks?

Sorry, I mis-copied my comment. I meant the watchdog being compatible
with the old
version.

Arnd

2022-06-16 21:31:49

by Tomer Maimon

[permalink] [raw]
Subject: Re: [PATCH v2 05/20] watchdog: npcm_wdt: Add NPCM845 watchdog support

Hi Arnd,

On Wed, 8 Jun 2022 at 16:05, Arnd Bergmann <[email protected]> wrote:
>
> On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <[email protected]> wrote:
> >
> > Add Nuvoton BMC NPCM845 watchdog support.
> > The NPCM845 uses the same watchdog as the NPCM750.
> >
> > Signed-off-by: Tomer Maimon <[email protected]>
>
> This one should no longer be needed if the timers are compatible with the
> old ones and correctly described in the DT.
by timers do you mean clocks?
>
> Arnd

Best regards,

Tomer