2022-07-21 10:28:13

by Tomer Maimon

[permalink] [raw]
Subject: [PATCH v1 2/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible

Add a compatible string for Nuvoton BMC NPCM845 PSPI.

Signed-off-by: Tomer Maimon <[email protected]>
---
Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt
index b98203ca656d..a4e72e52af59 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt
+++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt
@@ -3,7 +3,8 @@ Nuvoton NPCM Peripheral Serial Peripheral Interface(PSPI) controller driver
Nuvoton NPCM7xx SOC support two PSPI channels.

Required properties:
- - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC
+ - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX.
+ "nuvoton,npcm845-pspi" for Arbel NPCM8XX.
- #address-cells : should be 1. see spi-bus.txt
- #size-cells : should be 0. see spi-bus.txt
- specifies physical base address and size of the register.
--
2.33.0


2022-07-21 12:47:07

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible

On Thu, Jul 21, 2022 at 01:15:56PM +0300, Tomer Maimon wrote:

> Required properties:
> - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC
> + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX.
> + "nuvoton,npcm845-pspi" for Arbel NPCM8XX.

You've not updated the driver to accept this compatible and this doesn't
say anything about fallbacks.


Attachments:
(No filename) (368.00 B)
signature.asc (499.00 B)
Download all attachments

2022-07-21 15:30:26

by Tomer Maimon

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-binding: spi: npcm-pspi: Add npcm845 compatible

Hi Mark,

Thanks for your comment.

On Thu, 21 Jul 2022 at 15:09, Mark Brown <[email protected]> wrote:
>
> On Thu, Jul 21, 2022 at 01:15:56PM +0300, Tomer Maimon wrote:
>
> > Required properties:
> > - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC
> > + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX.
> > + "nuvoton,npcm845-pspi" for Arbel NPCM8XX.
>
> You've not updated the driver to accept this compatible and this doesn't
> say anything about fallbacks.

I will make sure to add the compatible to the driver

Thanks,

Tomer