2013-05-30 10:27:46

by Yijing Wang

Subject: [PATCH 7/7] tulip: remove redundant D0 power state set

Pci_enable_device() will set device power state to D0,
so it's no need to do it again in tulip_init_one().

Signed-off-by: Yijing Wang <[email protected]>
---
drivers/net/ethernet/dec/tulip/tulip_core.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
index 1e9443d..c94152f 100644
--- a/drivers/net/ethernet/dec/tulip/tulip_core.c
+++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
@@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
return i;
}

- /* The chip will fail to enter a low-power state later unless
- * first explicitly commanded into D0 */
- if (pci_set_power_state(pdev, PCI_D0)) {
- pr_notice("Failed to set power state to D0\n");
- }
-
irq = pdev->irq;

/* alloc_etherdev ensures aligned and zeroed private structures */
--
1.7.1

2013-05-30 15:31:46

by Grant Grundler

Subject: Re: [PATCH 7/7] tulip: remove redundant D0 power state set

On Thu, May 30, 2013 at 3:27 AM, Yijing Wang <[email protected]> wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in tulip_init_one().
>
> Signed-off-by: Yijing Wang <[email protected]>

Ack-by: Grant Grundler <[email protected]>

thanks!
grant

> ---
> drivers/net/ethernet/dec/tulip/tulip_core.c | 6 ------
> 1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 1e9443d..c94152f 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> return i;
> }
>
> - /* The chip will fail to enter a low-power state later unless
> - * first explicitly commanded into D0 */
> - if (pci_set_power_state(pdev, PCI_D0)) {
> - pr_notice("Failed to set power state to D0\n");
> - }
> -
> irq = pdev->irq;
>
> /* alloc_etherdev ensures aligned and zeroed private structures */
> --
> 1.7.1
>
>

2013-05-31 08:39:51

by David Miller

Subject: Re: [PATCH 7/7] tulip: remove redundant D0 power state set

From: Grant Grundler <[email protected]>
Date: Thu, 30 May 2013 08:31:38 -0700

> On Thu, May 30, 2013 at 3:27 AM, Yijing Wang <[email protected]> wrote:
>> Pci_enable_device() will set device power state to D0,
>> so it's no need to do it again in tulip_init_one().
>>
>> Signed-off-by: Yijing Wang <[email protected]>
>
> Ack-by: Grant Grundler <[email protected]>

(it's Acked-by) Applied, thanks.