2016-04-12 10:47:17

by Alexander Potapenko

Subject: [PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero

There's actually no point in reserving the zero hash value.

Reported-by: Joonsoo Kim <[email protected]>
---
lib/stackdepot.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 654c9d8..9e0b031 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -210,10 +210,6 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
goto fast_exit;

hash = hash_stack(trace->entries, trace->nr_entries);
- /* Bad luck, we won't store this stack. */
- if (hash == 0)
- goto exit;
-
bucket = &stack_table[hash & STACK_HASH_MASK];

/*
--
2.8.0.rc3.226.g39d4020

2016-04-13 08:51:51

by Andrey Ryabinin

Subject: Re: [PATCH v1] lib/stackdepot.c: allow the stack trace hash to be zero

2016-04-12 13:46 GMT+03:00 Alexander Potapenko <[email protected]>:
> There's actually no point in reserving the zero hash value.
>
> Reported-by: Joonsoo Kim <[email protected]>
> ---

No sign-off, poor changelog.