2015-08-27 10:34:44

by Javier Martinez Canillas

Subject: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers

These platform drivers have a platform device ID table but the module
alias information is not created so module autoloading will not work.

Signed-off-by: Javier Martinez Canillas <[email protected]>

---

drivers/rtc/rtc-ab8500.c | 1 +
drivers/rtc/rtc-max8997.c | 1 +
drivers/rtc/rtc-s5m.c | 1 +
3 files changed, 3 insertions(+)

diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 133d2e2e1a25..8537d1e3a995 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
{ "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
{ "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
};
+MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);

static int ab8500_rtc_probe(struct platform_device *pdev)
{
diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c
index 9e02bcda0c09..db984d4bf952 100644
--- a/drivers/rtc/rtc-max8997.c
+++ b/drivers/rtc/rtc-max8997.c
@@ -521,6 +521,7 @@ static const struct platform_device_id rtc_id[] = {
{ "max8997-rtc", 0 },
{},
};
+MODULE_DEVICE_TABLE(platform, rtc_id);

static struct platform_driver max8997_rtc_driver = {
.driver = {
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index ab60287ee72d..f2504b4eef34 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -807,6 +807,7 @@ static const struct platform_device_id s5m_rtc_id[] = {
{ "s2mps14-rtc", S2MPS14X },
{ },
};
+MODULE_DEVICE_TABLE(platform, s5m_rtc_id);

static struct platform_driver s5m_rtc_driver = {
.driver = {
--
2.4.3

2015-08-27 12:20:37

by Andrey Ryabinin

Subject: Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers

2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <[email protected]>:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 133d2e2e1a25..8537d1e3a995 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },

Completely irrelevant, but this array should have an empty terminating element.

> };
> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>

2015-08-27 12:23:23

by Javier Martinez Canillas

Subject: Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers

Hello Andrey,

On 08/27/2015 02:20 PM, Andrey Ryabinin wrote:
> 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <[email protected]>:
>> These platform drivers have a platform device ID table but the module
>> alias information is not created so module autoloading will not work.
>>
>> Signed-off-by: Javier Martinez Canillas <[email protected]>
>>
>> ---
>>
>> drivers/rtc/rtc-ab8500.c | 1 +
>> drivers/rtc/rtc-max8997.c | 1 +
>> drivers/rtc/rtc-s5m.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
>> index 133d2e2e1a25..8537d1e3a995 100644
>> --- a/drivers/rtc/rtc-ab8500.c
>> +++ b/drivers/rtc/rtc-ab8500.c
>> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
>> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
>> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
>
> Completely irrelevant, but this array should have an empty terminating element.
>

You are right, it's missing a sentinel indeed. But
that change should be done in a separate patch.

>> };
>> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

2015-08-28 00:27:47

by Krzysztof Kozlowski

Subject: Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers

On 27.08.2015 19:34, Javier Martinez Canillas wrote:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)

Makes sense:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2015-08-31 20:09:47

by Alexandre Belloni

Subject: Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers

On 27/08/2015 at 12:34:32 +0200, Javier Martinez Canillas wrote :
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Applied, thanks.

--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com