2017-06-07 09:33:41

by Alexandre Courbot

[permalink] [raw]
Subject: [PATCH] [media] media-ioc-g-topology.rst: fix typos

Fix what seems to be a few typos induced by copy/paste.

Signed-off-by: Alexandre Courbot <[email protected]>
---
Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
index 48c9531f4db0..5f2d82756033 100644
--- a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
+++ b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
@@ -241,7 +241,7 @@ desired arrays with the media graph elements.

.. c:type:: media_v2_intf_devnode

-.. flat-table:: struct media_v2_interface
+.. flat-table:: struct media_v2_devnode
:header-rows: 0
:stub-columns: 0
:widths: 1 2 8
@@ -312,7 +312,7 @@ desired arrays with the media graph elements.

.. c:type:: media_v2_link

-.. flat-table:: struct media_v2_pad
+.. flat-table:: struct media_v2_link
:header-rows: 0
:stub-columns: 0
:widths: 1 2 8
@@ -324,7 +324,7 @@ desired arrays with the media graph elements.

- ``id``

- - Unique ID for the pad.
+ - Unique ID for the link.

- .. row 2

@@ -334,7 +334,7 @@ desired arrays with the media graph elements.

- On pad to pad links: unique ID for the source pad.

- On interface to entity links: unique ID for the interface.
+ On interface to entity links: unique ID for the entity.

- .. row 3

--
2.13.0.506.g27d5fe0cd-goog


2017-06-08 17:51:45

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH] [media] media-ioc-g-topology.rst: fix typos

Em Wed, 7 Jun 2017 18:33:02 +0900
Alexandre Courbot <[email protected]> escreveu:

> Fix what seems to be a few typos induced by copy/paste.
>
> Signed-off-by: Alexandre Courbot <[email protected]>
> ---
> Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
> index 48c9531f4db0..5f2d82756033 100644
> --- a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
> +++ b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
> @@ -241,7 +241,7 @@ desired arrays with the media graph elements.
>
> .. c:type:: media_v2_intf_devnode
>
> -.. flat-table:: struct media_v2_interface
> +.. flat-table:: struct media_v2_devnode
> :header-rows: 0
> :stub-columns: 0
> :widths: 1 2 8

Actually the fix is wrong here :-)

I'll just fold the following diff to your patch:

diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
index 5f2d82756033..add8281494f8 100644
--- a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
+++ b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
@@ -241,7 +241,7 @@ desired arrays with the media graph elements.

.. c:type:: media_v2_intf_devnode

-.. flat-table:: struct media_v2_devnode
+.. flat-table:: struct media_v2_intf_devnode
:header-rows: 0
:stub-columns: 0
:widths: 1 2 8

Thanks,
Mauro

2017-06-10 03:04:12

by Alexandre Courbot

[permalink] [raw]
Subject: Re: [PATCH] [media] media-ioc-g-topology.rst: fix typos

On Fri, Jun 9, 2017 at 2:51 AM, Mauro Carvalho Chehab
<[email protected]> wrote:
> Em Wed, 7 Jun 2017 18:33:02 +0900
> Alexandre Courbot <[email protected]> escreveu:
>
>> Fix what seems to be a few typos induced by copy/paste.
>>
>> Signed-off-by: Alexandre Courbot <[email protected]>
>> ---
>> Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
>> index 48c9531f4db0..5f2d82756033 100644
>> --- a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
>> +++ b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
>> @@ -241,7 +241,7 @@ desired arrays with the media graph elements.
>>
>> .. c:type:: media_v2_intf_devnode
>>
>> -.. flat-table:: struct media_v2_interface
>> +.. flat-table:: struct media_v2_devnode
>> :header-rows: 0
>> :stub-columns: 0
>> :widths: 1 2 8
>
> Actually the fix is wrong here :-)

Whoopsie. Apologies for not double-checking. >_<

>
> I'll just fold the following diff to your patch:
>
> diff --git a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
> index 5f2d82756033..add8281494f8 100644
> --- a/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
> +++ b/Documentation/media/uapi/mediactl/media-ioc-g-topology.rst
> @@ -241,7 +241,7 @@ desired arrays with the media graph elements.
>
> .. c:type:: media_v2_intf_devnode
>
> -.. flat-table:: struct media_v2_devnode
> +.. flat-table:: struct media_v2_intf_devnode
> :header-rows: 0
> :stub-columns: 0
> :widths: 1 2 8

Looks perfect now. Thanks for catching this!