2014-07-05 02:35:28

by Nicholas Krause

[permalink] [raw]
Subject: arc: FIXME in file uwind.c

When using cscope I get a FIX ME message in uwind.c , it seems to have
four NULL returns.
I am wondering since I am new to part of the kernel what would you
like me to return here?
Cheers Nick


2014-07-24 04:39:00

by Vineet Gupta

[permalink] [raw]
Subject: Re: arc: FIXME in file uwind.c

Hi Nick,

On Saturday 05 July 2014 08:05 AM, Nick Krause wrote:
> When using cscope I get a FIX ME message in uwind.c , it seems to have
> four NULL returns.
> I am wondering since I am new to part of the kernel what would you
> like me to return here?
> Cheers Nick

The issues were related to incorrect .debug_frame stuff generated by gcc at the
time. The current unwinder works well so we've not had the need to revisit it.

Thx,
-Vineet

2014-07-24 04:42:24

by Nicholas Krause

[permalink] [raw]
Subject: Re: arc: FIXME in file uwind.c

On Thu, Jul 24, 2014 at 12:38 AM, Vineet Gupta
<[email protected]> wrote:
> Hi Nick,
>
> On Saturday 05 July 2014 08:05 AM, Nick Krause wrote:
>> When using cscope I get a FIX ME message in uwind.c , it seems to have
>> four NULL returns.
>> I am wondering since I am new to part of the kernel what would you
>> like me to return here?
>> Cheers Nick
>
> The issues were related to incorrect .debug_frame stuff generated by gcc at the
> time. The current unwinder works well so we've not had the need to revisit it.
>
> Thx,
> -Vineet
Finally , a nice comment :). I seem to be getting hate for some bad patches.
Probably should quit :(.
Nick