This fixes the latency for the cpufreq policy to 1 million nanoseconds
that calls the function pxa_cpu_init for the member of the structure
called cpuinfo.transition_latency.
Signed-off-by: Nicholas Krause <[email protected]>
---
drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index e24269a..e08bb98 100644
--- a/drivers/cpufreq/pxa2xx-cpufreq.c
+++ b/drivers/cpufreq/pxa2xx-cpufreq.c
@@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
init_sdram_rows();
/* set default policy and cpuinfo */
- policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
+ policy->cpuinfo.transition_latency = 1000000;
/* Generate pxa25x the run cpufreq_frequency_table struct */
for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
--
1.9.1
On 14 July 2014 11:58, Nicholas Krause <[email protected]> wrote:
> This fixes the latency for the cpufreq policy to 1 million nanoseconds
> that calls the function pxa_cpu_init for the member of the structure
> called cpuinfo.transition_latency.
>
> Signed-off-by: Nicholas Krause <[email protected]>
> ---
> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
> index e24269a..e08bb98 100644
> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
> init_sdram_rows();
>
> /* set default policy and cpuinfo */
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000000;
>
> /* Generate pxa25x the run cpufreq_frequency_table struct */
> for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
Acked-by: Viresh Kumar <[email protected]>
Viresh,
Be careful when you ACK Nick's patches. He has confessed he has no
idea how to build test a kernel. His patches are NOT AT ALL build
tested. And some of his patches are being reverted for causing
problems in build and all. He looks for FIXME and removes/edits the
code as per the comments. Just be careful.
On Mon, Jul 14, 2014 at 12:00 PM, Viresh Kumar <[email protected]> wrote:
> On 14 July 2014 11:58, Nicholas Krause <[email protected]> wrote:
>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>> that calls the function pxa_cpu_init for the member of the structure
>> called cpuinfo.transition_latency.
>>
>> Signed-off-by: Nicholas Krause <[email protected]>
>> ---
>> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>> index e24269a..e08bb98 100644
>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>> init_sdram_rows();
>>
>> /* set default policy and cpuinfo */
>> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>> + policy->cpuinfo.transition_latency = 1000000;
>>
>> /* Generate pxa25x the run cpufreq_frequency_table struct */
>> for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
>
> Acked-by: Viresh Kumar <[email protected]>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Thanks and Regards
Pramod
On Fri, Jul 25, 2014 at 1:36 AM, pramod gurav
<[email protected]> wrote:
> Viresh,
> Be careful when you ACK Nick's patches. He has confessed he has no
> idea how to build test a kernel. His patches are NOT AT ALL build
> tested. And some of his patches are being reverted for causing
> problems in build and all. He looks for FIXME and removes/edits the
> code as per the comments. Just be careful.
>
> On Mon, Jul 14, 2014 at 12:00 PM, Viresh Kumar <[email protected]> wrote:
>> On 14 July 2014 11:58, Nicholas Krause <[email protected]> wrote:
>>> This fixes the latency for the cpufreq policy to 1 million nanoseconds
>>> that calls the function pxa_cpu_init for the member of the structure
>>> called cpuinfo.transition_latency.
>>>
>>> Signed-off-by: Nicholas Krause <[email protected]>
>>> ---
>>> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
>>> index e24269a..e08bb98 100644
>>> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
>>> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
>>> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>>> init_sdram_rows();
>>>
>>> /* set default policy and cpuinfo */
>>> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
>>> + policy->cpuinfo.transition_latency = 1000000;
>>>
>>> /* Generate pxa25x the run cpufreq_frequency_table struct */
>>> for (i = 0; i < NUM_PXA25x_RUN_FREQS; i++) {
>>
>> Acked-by: Viresh Kumar <[email protected]>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Thanks and Regards
> Pramod
Pramod,
I learned how to do it today and Viresh checked this and it didn't build
so I sent him another fixed patch :). I am learning fast now and known
how to properly test my patches now.
Nick