2014-07-22 21:09:53

by Nicholas Krause

Subject: omap-wakeupgen.c: Remove function for fix me

static void __init irq_pm_init(void)
382 {
383 /* FIXME: Remove this when MPU OSWR support is added */
384 if (!soc_is_omap54xx())
385 cpu_pm_register_notifier(&irq_notifier_block);
386 }
I am wondering is this omap supported now if it is can I remove it?
Cheers Nick

2014-07-23 07:44:56

by Tony Lindgren

Subject: Re: omap-wakeupgen.c: Remove function for fix me

* Nick Krause <[email protected]> [140722 14:12]:
> static void __init irq_pm_init(void)
> 382 {
> 383 /* FIXME: Remove this when MPU OSWR support is added */
> 384 if (!soc_is_omap54xx())
> 385 cpu_pm_register_notifier(&irq_notifier_block);
> 386 }
> I am wondering is this omap supported now if it is can I remove it?

Does REVISIT cause issues for you with cscope? It may be easier to
replace the cscope bugging FIXME statements with just REVISIT unless
a real fix is provided.

Regards,

Tony

2014-07-23 15:08:54

by Nicholas Krause

Subject: Re: omap-wakeupgen.c: Remove function for fix me

On Wed, Jul 23, 2014 at 3:43 AM, Tony Lindgren <[email protected]> wrote:
> * Nick Krause <[email protected]> [140722 14:12]:
>> static void __init irq_pm_init(void)
>> 382 {
>> 383 /* FIXME: Remove this when MPU OSWR support is added */
>> 384 if (!soc_is_omap54xx())
>> 385 cpu_pm_register_notifier(&irq_notifier_block);
>> 386 }
>> I am wondering is this omap supported now if it is can I remove it?
>
> Does REVISIT cause issues for you with cscope? It may be easier to
> replace the cscope bugging FIXME statements with just REVISIT unless
> a real fix is provided.
>
> Regards,
>
> Tony


Very well then , seems like a good idea will try later.
Nick