2023-12-09 17:11:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: mmc: synopsys-dw-mshc: add iommus for Intel SocFPGA

The DW MSHC node in Intel SocFPGA ARM64 DTS has iommus property, so
allow it to silence dtbs_check warnings:

socfpga_n5x_socdk.dtb: mmc@ff808000: Unevaluated properties are not allowed ('iommus' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

I assume the DTS represents the hardware, thus iommus is real.
---
Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
index b13b5166d20a..a6292777e376 100644
--- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
+++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
@@ -35,6 +35,9 @@ properties:
- const: biu
- const: ciu

+ iommus:
+ maxItems: 1
+
altr,sysmgr-syscon:
$ref: /schemas/types.yaml#/definitions/phandle-array
items:
@@ -62,6 +65,7 @@ allOf:
altr,sysmgr-syscon: true
else:
properties:
+ iommus: false
altr,sysmgr-syscon: false

required:
--
2.34.1


2023-12-12 17:06:21

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mmc: synopsys-dw-mshc: add iommus for Intel SocFPGA

On Sat, Dec 09, 2023 at 06:10:13PM +0100, Krzysztof Kozlowski wrote:
> The DW MSHC node in Intel SocFPGA ARM64 DTS has iommus property, so
> allow it to silence dtbs_check warnings:
>
> socfpga_n5x_socdk.dtb: mmc@ff808000: Unevaluated properties are not allowed ('iommus' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> I assume the DTS represents the hardware, thus iommus is real.

Assuming it is in fact real,
Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

> ---
> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> index b13b5166d20a..a6292777e376 100644
> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> @@ -35,6 +35,9 @@ properties:
> - const: biu
> - const: ciu
>
> + iommus:
> + maxItems: 1
> +
> altr,sysmgr-syscon:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> items:
> @@ -62,6 +65,7 @@ allOf:
> altr,sysmgr-syscon: true
> else:
> properties:
> + iommus: false
> altr,sysmgr-syscon: false
>
> required:
> --
> 2.34.1
>

Attachments:
(No filename) (1.39 kB)
 signature.asc (235.00 B)
 Download all attachments

2024-01-02 16:57:42

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mmc: synopsys-dw-mshc: add iommus for Intel SocFPGA

On Sat, 9 Dec 2023 at 18:10, Krzysztof Kozlowski
<[email protected]> wrote:
>
> The DW MSHC node in Intel SocFPGA ARM64 DTS has iommus property, so
> allow it to silence dtbs_check warnings:
>
> socfpga_n5x_socdk.dtb: mmc@ff808000: Unevaluated properties are not allowed ('iommus' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


>
> ---
>
> I assume the DTS represents the hardware, thus iommus is real.
> ---
> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> index b13b5166d20a..a6292777e376 100644
> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.yaml
> @@ -35,6 +35,9 @@ properties:
> - const: biu
> - const: ciu
>
> + iommus:
> + maxItems: 1
> +
> altr,sysmgr-syscon:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> items:
> @@ -62,6 +65,7 @@ allOf:
> altr,sysmgr-syscon: true
> else:
> properties:
> + iommus: false
> altr,sysmgr-syscon: false
>
> required:
> --
> 2.34.1
>