2023-02-17 08:30:15

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] mmc: meson-gx: Use devm_platform_get_and_ioremap_resource()

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <[email protected]>
---
drivers/mmc/host/meson-gx-mmc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 079c52dbeca6..a5a9a19a9a42 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -1204,8 +1204,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
if (ret)
return dev_err_probe(&pdev->dev, ret, "device reset failed\n");

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- host->regs = devm_ioremap_resource(&pdev->dev, res);
+ host->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(host->regs))
return PTR_ERR(host->regs);

--
2.20.1.7.g153144c



2023-02-17 10:57:05

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH -next] mmc: meson-gx: Use devm_platform_get_and_ioremap_resource()

On Fri, 17 Feb 2023 at 09:30, Yang Li <[email protected]> wrote:
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/meson-gx-mmc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 079c52dbeca6..a5a9a19a9a42 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -1204,8 +1204,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
> if (ret)
> return dev_err_probe(&pdev->dev, ret, "device reset failed\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - host->regs = devm_ioremap_resource(&pdev->dev, res);
> + host->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(host->regs))
> return PTR_ERR(host->regs);
>
> --
> 2.20.1.7.g153144c
>