2024-02-17 13:57:46

by Maulik Shah (mkshah)

Subject: [PATCH 1/2] soc: qcom: Update init level to core_initcall() for cmd-db and rpmh-rsc

cmd-db and rpmh-rsc are used by clients like regulators, interconnects and
clocks for resource voting. These clients are in core_initcall() while
cmd-db and rpmh-rsc are in arch_initcall(). Update init level for these
drivers also to core_initcall() to avoid unnecessary probe defer during
boot up.

Signed-off-by: Maulik Shah <[email protected]>
---
drivers/soc/qcom/cmd-db.c | 2 +-
drivers/soc/qcom/rpmh-rsc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index a5fd68411bed..c344107bc36c 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -362,7 +362,7 @@ static int __init cmd_db_device_init(void)
{
return platform_driver_register(&cmd_db_dev_driver);
}
-arch_initcall(cmd_db_device_init);
+core_initcall(cmd_db_device_init);

MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Command DB Driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
index a021dc71807b..c4c7aad957e6 100644
--- a/drivers/soc/qcom/rpmh-rsc.c
+++ b/drivers/soc/qcom/rpmh-rsc.c
@@ -1154,7 +1154,7 @@ static int __init rpmh_driver_init(void)
{
return platform_driver_register(&rpmh_driver);
}
-arch_initcall(rpmh_driver_init);
+core_initcall(rpmh_driver_init);

MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver");
MODULE_LICENSE("GPL v2");

--
2.22.0

2024-02-28 15:42:33

by Ulf Hansson

Subject: Re: [PATCH 1/2] soc: qcom: Update init level to core_initcall() for cmd-db and rpmh-rsc

On Sat, 17 Feb 2024 at 14:57, Maulik Shah <[email protected]> wrote:
>
> cmd-db and rpmh-rsc are used by clients like regulators, interconnects and
> clocks for resource voting. These clients are in core_initcall() while
> cmd-db and rpmh-rsc are in arch_initcall(). Update init level for these
> drivers also to core_initcall() to avoid unnecessary probe defer during
> boot up.
>
> Signed-off-by: Maulik Shah <[email protected]>

Reviewed-by: Ulf Hansson <[email protected]>

Kind regards
Uffe

> ---
> drivers/soc/qcom/cmd-db.c | 2 +-
> drivers/soc/qcom/rpmh-rsc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index a5fd68411bed..c344107bc36c 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -362,7 +362,7 @@ static int __init cmd_db_device_init(void)
> {
> return platform_driver_register(&cmd_db_dev_driver);
> }
> -arch_initcall(cmd_db_device_init);
> +core_initcall(cmd_db_device_init);
>
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Command DB Driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index a021dc71807b..c4c7aad957e6 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -1154,7 +1154,7 @@ static int __init rpmh_driver_init(void)
> {
> return platform_driver_register(&rpmh_driver);
> }
> -arch_initcall(rpmh_driver_init);
> +core_initcall(rpmh_driver_init);
>
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver");
> MODULE_LICENSE("GPL v2");
>
> --
> 2.22.0
>

2024-04-04 11:07:49

by Ulf Hansson

Subject: Re: [PATCH 1/2] soc: qcom: Update init level to core_initcall() for cmd-db and rpmh-rsc

On Sat, 17 Feb 2024 at 14:57, Maulik Shah <[email protected]> wrote:
>
> cmd-db and rpmh-rsc are used by clients like regulators, interconnects and
> clocks for resource voting. These clients are in core_initcall() while
> cmd-db and rpmh-rsc are in arch_initcall(). Update init level for these
> drivers also to core_initcall() to avoid unnecessary probe defer during
> boot up.
>
> Signed-off-by: Maulik Shah <[email protected]>

I have picked up patch2, leaving this one for Bjorn/Konrad to manage.

Kind regards
Uffe


> ---
> drivers/soc/qcom/cmd-db.c | 2 +-
> drivers/soc/qcom/rpmh-rsc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index a5fd68411bed..c344107bc36c 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -362,7 +362,7 @@ static int __init cmd_db_device_init(void)
> {
> return platform_driver_register(&cmd_db_dev_driver);
> }
> -arch_initcall(cmd_db_device_init);
> +core_initcall(cmd_db_device_init);
>
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Command DB Driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index a021dc71807b..c4c7aad957e6 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -1154,7 +1154,7 @@ static int __init rpmh_driver_init(void)
> {
> return platform_driver_register(&rpmh_driver);
> }
> -arch_initcall(rpmh_driver_init);
> +core_initcall(rpmh_driver_init);
>
> MODULE_DESCRIPTION("Qualcomm Technologies, Inc. RPMh Driver");
> MODULE_LICENSE("GPL v2");
>
> --
> 2.22.0
>