2020-08-24 01:07:23

by Tian Tao

Subject: [PATCH] mmc: sd: Use kobj_to_dev() instead of container_of()

Use kobj_to_dev() instead of container_of()

Signed-off-by: Tian Tao <[email protected]>
---
drivers/mmc/core/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index 5a2210c..a0d2c34 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -735,7 +735,7 @@ static struct attribute *sd_std_attrs[] = {
static umode_t sd_std_is_visible(struct kobject *kobj, struct attribute *attr,
int index)
{
- struct device *dev = container_of(kobj, struct device, kobj);
+ struct device *dev = kobj_to_dev(kobj);
struct mmc_card *card = mmc_dev_to_card(dev);

/* CIS vendor and device ids are available only for Combo cards */
--
2.7.4

2020-08-28 08:48:19

by Ulf Hansson

Subject: Re: [PATCH] mmc: sd: Use kobj_to_dev() instead of container_of()

On Mon, 24 Aug 2020 at 03:04, Tian Tao <[email protected]> wrote:
>
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Tian Tao <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/core/sd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 5a2210c..a0d2c34 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -735,7 +735,7 @@ static struct attribute *sd_std_attrs[] = {
> static umode_t sd_std_is_visible(struct kobject *kobj, struct attribute *attr,
> int index)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
> struct mmc_card *card = mmc_dev_to_card(dev);
>
> /* CIS vendor and device ids are available only for Combo cards */
> --
> 2.7.4
>