2023-09-15 11:44:47

by Ulf Hansson

[permalink] [raw]
Subject: [PATCH v2 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem

The Kconfig belongs closer to the corresponding implementation, hence let's
move it from the soc subsystem to the pmdomain subsystem.

Cc: Walker Chen <[email protected]>
Cc: Conor Dooley <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Signed-off-by: Ulf Hansson <[email protected]>
---
MAINTAINERS | 3 +--
drivers/pmdomain/Kconfig | 1 +
drivers/{soc => pmdomain}/starfive/Kconfig | 0
drivers/soc/Kconfig | 1 -
4 files changed, 2 insertions(+), 3 deletions(-)
rename drivers/{soc => pmdomain}/starfive/Kconfig (100%)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6b491ebcf790..40744fefed3d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20515,7 +20515,7 @@ M: Walker Chen <[email protected]>
M: Changhuang Liang <[email protected]>
S: Supported
F: Documentation/devicetree/bindings/power/starfive*
-F: drivers/pmdomain/starfive/jh71xx-pmu.c
+F: drivers/pmdomain/starfive/
F: include/dt-bindings/power/starfive,jh7110-pmu.h

STARFIVE SOC DRIVERS
@@ -20523,7 +20523,6 @@ M: Conor Dooley <[email protected]>
S: Maintained
T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/
F: Documentation/devicetree/bindings/soc/starfive/
-F: drivers/soc/starfive/

STARFIVE TRNG DRIVER
M: Jia Jie Ho <[email protected]>
diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
index 08f8a3aa9805..2286c36076db 100644
--- a/drivers/pmdomain/Kconfig
+++ b/drivers/pmdomain/Kconfig
@@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig"
source "drivers/pmdomain/rockchip/Kconfig"
source "drivers/pmdomain/samsung/Kconfig"
source "drivers/pmdomain/st/Kconfig"
+source "drivers/pmdomain/starfive/Kconfig"

endmenu
diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig
similarity index 100%
rename from drivers/soc/starfive/Kconfig
rename to drivers/pmdomain/starfive/Kconfig
diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
index 8b46da40f107..10a9ff84ff41 100644
--- a/drivers/soc/Kconfig
+++ b/drivers/soc/Kconfig
@@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig"
source "drivers/soc/rockchip/Kconfig"
source "drivers/soc/samsung/Kconfig"
source "drivers/soc/sifive/Kconfig"
-source "drivers/soc/starfive/Kconfig"
source "drivers/soc/sunxi/Kconfig"
source "drivers/soc/tegra/Kconfig"
source "drivers/soc/ti/Kconfig"
--
2.34.1


2023-09-15 12:39:30

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v2 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem

On Fri, Sep 15, 2023 at 11:19:59AM +0200, Ulf Hansson wrote:
> The Kconfig belongs closer to the corresponding implementation, hence let's
> move it from the soc subsystem to the pmdomain subsystem.

Thanks for updating the MAINTAINERS bits.

> Cc: Walker Chen <[email protected]>
> Cc: Conor Dooley <[email protected]>
> Acked-by: Conor Dooley <[email protected]>

Unless my macro changed without me noticing, I don't think that's
the email address I used for the ack. Just to be sure:
Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

> Signed-off-by: Ulf Hansson <[email protected]>
> ---
> MAINTAINERS | 3 +--
> drivers/pmdomain/Kconfig | 1 +
> drivers/{soc => pmdomain}/starfive/Kconfig | 0
> drivers/soc/Kconfig | 1 -
> 4 files changed, 2 insertions(+), 3 deletions(-)
> rename drivers/{soc => pmdomain}/starfive/Kconfig (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6b491ebcf790..40744fefed3d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20515,7 +20515,7 @@ M: Walker Chen <[email protected]>
> M: Changhuang Liang <[email protected]>
> S: Supported
> F: Documentation/devicetree/bindings/power/starfive*
> -F: drivers/pmdomain/starfive/jh71xx-pmu.c
> +F: drivers/pmdomain/starfive/
> F: include/dt-bindings/power/starfive,jh7110-pmu.h
>
> STARFIVE SOC DRIVERS
> @@ -20523,7 +20523,6 @@ M: Conor Dooley <[email protected]>
> S: Maintained
> T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/
> F: Documentation/devicetree/bindings/soc/starfive/
> -F: drivers/soc/starfive/
>
> STARFIVE TRNG DRIVER
> M: Jia Jie Ho <[email protected]>
> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> index 08f8a3aa9805..2286c36076db 100644
> --- a/drivers/pmdomain/Kconfig
> +++ b/drivers/pmdomain/Kconfig
> @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig"
> source "drivers/pmdomain/rockchip/Kconfig"
> source "drivers/pmdomain/samsung/Kconfig"
> source "drivers/pmdomain/st/Kconfig"
> +source "drivers/pmdomain/starfive/Kconfig"
>
> endmenu
> diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig
> similarity index 100%
> rename from drivers/soc/starfive/Kconfig
> rename to drivers/pmdomain/starfive/Kconfig
> diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
> index 8b46da40f107..10a9ff84ff41 100644
> --- a/drivers/soc/Kconfig
> +++ b/drivers/soc/Kconfig
> @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig"
> source "drivers/soc/rockchip/Kconfig"
> source "drivers/soc/samsung/Kconfig"
> source "drivers/soc/sifive/Kconfig"
> -source "drivers/soc/starfive/Kconfig"
> source "drivers/soc/sunxi/Kconfig"
> source "drivers/soc/tegra/Kconfig"
> source "drivers/soc/ti/Kconfig"
> --
> 2.34.1
>


Attachments:
(No filename) (2.88 kB)
signature.asc (235.00 B)
Download all attachments

2023-09-15 16:55:17

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH v2 13/17] pmdomain: starfive: Move Kconfig file to the pmdomain subsystem

On Fri, 15 Sept 2023 at 11:30, Conor Dooley <[email protected]> wrote:
>
> On Fri, Sep 15, 2023 at 11:19:59AM +0200, Ulf Hansson wrote:
> > The Kconfig belongs closer to the corresponding implementation, hence let's
> > move it from the soc subsystem to the pmdomain subsystem.
>
> Thanks for updating the MAINTAINERS bits.
>
> > Cc: Walker Chen <[email protected]>
> > Cc: Conor Dooley <[email protected]>
> > Acked-by: Conor Dooley <[email protected]>
>
> Unless my macro changed without me noticing, I don't think that's
> the email address I used for the ack. Just to be sure:
> Acked-by: Conor Dooley <[email protected]>

Sorry, my bad. I will change it, if/when applying. Thanks again!

Kind regards
Uffe

>
> Thanks,
> Conor.
>
> > Signed-off-by: Ulf Hansson <[email protected]>
> > ---
> > MAINTAINERS | 3 +--
> > drivers/pmdomain/Kconfig | 1 +
> > drivers/{soc => pmdomain}/starfive/Kconfig | 0
> > drivers/soc/Kconfig | 1 -
> > 4 files changed, 2 insertions(+), 3 deletions(-)
> > rename drivers/{soc => pmdomain}/starfive/Kconfig (100%)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6b491ebcf790..40744fefed3d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20515,7 +20515,7 @@ M: Walker Chen <[email protected]>
> > M: Changhuang Liang <[email protected]>
> > S: Supported
> > F: Documentation/devicetree/bindings/power/starfive*
> > -F: drivers/pmdomain/starfive/jh71xx-pmu.c
> > +F: drivers/pmdomain/starfive/
> > F: include/dt-bindings/power/starfive,jh7110-pmu.h
> >
> > STARFIVE SOC DRIVERS
> > @@ -20523,7 +20523,6 @@ M: Conor Dooley <[email protected]>
> > S: Maintained
> > T: git https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/
> > F: Documentation/devicetree/bindings/soc/starfive/
> > -F: drivers/soc/starfive/
> >
> > STARFIVE TRNG DRIVER
> > M: Jia Jie Ho <[email protected]>
> > diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> > index 08f8a3aa9805..2286c36076db 100644
> > --- a/drivers/pmdomain/Kconfig
> > +++ b/drivers/pmdomain/Kconfig
> > @@ -12,5 +12,6 @@ source "drivers/pmdomain/renesas/Kconfig"
> > source "drivers/pmdomain/rockchip/Kconfig"
> > source "drivers/pmdomain/samsung/Kconfig"
> > source "drivers/pmdomain/st/Kconfig"
> > +source "drivers/pmdomain/starfive/Kconfig"
> >
> > endmenu
> > diff --git a/drivers/soc/starfive/Kconfig b/drivers/pmdomain/starfive/Kconfig
> > similarity index 100%
> > rename from drivers/soc/starfive/Kconfig
> > rename to drivers/pmdomain/starfive/Kconfig
> > diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig
> > index 8b46da40f107..10a9ff84ff41 100644
> > --- a/drivers/soc/Kconfig
> > +++ b/drivers/soc/Kconfig
> > @@ -23,7 +23,6 @@ source "drivers/soc/renesas/Kconfig"
> > source "drivers/soc/rockchip/Kconfig"
> > source "drivers/soc/samsung/Kconfig"
> > source "drivers/soc/sifive/Kconfig"
> > -source "drivers/soc/starfive/Kconfig"
> > source "drivers/soc/sunxi/Kconfig"
> > source "drivers/soc/tegra/Kconfig"
> > source "drivers/soc/ti/Kconfig"
> > --
> > 2.34.1
> >