2024-03-06 11:42:51

by Ricardo B. Marliere

Subject: [PATCH] mmc: core: make mmc_host_class constant

Since commit 43a7206b0963 ("driver core: class: make class_register() take
a const *"), the driver core allows for struct class to be in read-only
memory, so move the mmc_host_class structure to be declared at build time
placing it into read-only memory, instead of having to be dynamically
allocated at boot time.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/mmc/core/host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 3aa9dda6fd4f..8f8781d6c25e 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -88,7 +88,7 @@ static int mmc_host_classdev_shutdown(struct device *dev)
return 0;
}

-static struct class mmc_host_class = {
+static const struct class mmc_host_class = {
.name = "mmc_host",
.dev_release = mmc_host_classdev_release,
.shutdown_pre = mmc_host_classdev_shutdown,

---
base-commit: 0cd8fd15a75e82ef249e99b3d80e2012a729d028
change-id: 20240305-class_cleanup-mmc-75258142f27e

Best regards,
--
Ricardo B. Marliere <[email protected]>

2024-03-06 22:43:30

by Ulf Hansson

Subject: Re: [PATCH] mmc: core: make mmc_host_class constant

On Tue, 5 Mar 2024 at 20:49, Ricardo B. Marliere <[email protected]> wrote:
>
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the mmc_host_class structure to be declared at build time
> placing it into read-only memory, instead of having to be dynamically
> allocated at boot time.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/core/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 3aa9dda6fd4f..8f8781d6c25e 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -88,7 +88,7 @@ static int mmc_host_classdev_shutdown(struct device *dev)
> return 0;
> }
>
> -static struct class mmc_host_class = {
> +static const struct class mmc_host_class = {
> .name = "mmc_host",
> .dev_release = mmc_host_classdev_release,
> .shutdown_pre = mmc_host_classdev_shutdown,
>
> ---
> base-commit: 0cd8fd15a75e82ef249e99b3d80e2012a729d028
> change-id: 20240305-class_cleanup-mmc-75258142f27e
>
> Best regards,
> --
> Ricardo B. Marliere <[email protected]>
>