2024-01-03 22:31:34

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v8 1/2] dt-bindings: mmc: brcm,sdhci-brcmstb: Add support for 74165b0

On 1/3/24 14:23, Kamal Dasu wrote:
> From: Kamal Dasu <[email protected]>
>
> With newer sdio controller core used for 74165b0 we need to update
> the compatibility with "brcm,bcm74165b0-sdhci".
>
> Signed-off-by: Kamal Dasu <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2024-01-05 10:20:51

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH v8 0/2] mmc: sdhci-brcmstb: add new sdhci reset sequence for brcm 74165b0

On Wed, 3 Jan 2024 at 23:23, Kamal Dasu <[email protected]> wrote:
>
> v8 changes
> - Add subject as "mmc: sdhci-brcmstb:" to PATCH 2/2
> - Added Acked tag to PATCH 2/2 commit message
>
> v7 changes:
> - Moved variable longer line to be first
> - Used read_poll_timeout_atomic() and fixed break condition as per
> review comments
>
> v6 changes:
> - PATCH 1/2 Acked-by: Krzysztof Kozlowski <[email protected]>
> - PATCH 2/2 replaced readb_poll_timeout() with readb_poll_timeout_atomic()
> based on Review comments
>
> v5 changes:
> - got rid of 'Reported by:' and 'Closes:' tags for all patches
>
> v4 changes:
> - Fix for v3 changes that introduced dt schema errors
> - Fix for v3 changes that introduced sdhci-brcmstb build warnings
> - Added proper PATCH format and cleanup commit messages as per
> review comments. Added proper 'Reported-by' and 'Closes' tags
> - Added comments for 32-bit register access as per review comments
> - Replaced wait loop polling with readb_poll_timeout() helper as per
> review comments for the sdhci-brcmstb driver changes
>
> v3 changes:
> - Removed extra emun arrayfor possible compatible strings
> - shdci-brcmstb checkpatch warning fixes
>
> v2 changes:
> - Fixed devicetree bindings for shdci-brcmstb and removed 74165 compatible
> string as per review comments
>
>
> Kamal Dasu (2):
> dt-bindings: mmc: brcm,sdhci-brcmstb: Add support for 74165b0
> mmc: sdhci-brcmstb: add new sdhci reset sequence for brcm 74165b0
>
> .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 4 +-
> drivers/mmc/host/sdhci-brcmstb.c | 69 +++++++++++++++++--
> 2 files changed, 65 insertions(+), 8 deletions(-)
>

Applied for next, thanks!

Kind regards
Uffe