2021-12-09 12:19:25

by Lizhe

Subject: [PATCH] drivers/mmc/core/bus: Remove redundant driver match function

If there is no driver match function, the driver core assumes
that each candidate pair (driver, device) matches. See function
driver_match_device().

Drop the mmc bus's match function that always returned 1 and
so implements the same behaviour as when there is no match
function.

Signed-off-by: lizhe <[email protected]>
---
drivers/mmc/core/bus.c | 11 -----------
1 file changed, 11 deletions(-)

diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
index f6b7a9c5bbff..096ae624be9a 100644
--- a/drivers/mmc/core/bus.c
+++ b/drivers/mmc/core/bus.c
@@ -53,16 +53,6 @@ static struct attribute *mmc_dev_attrs[] = {
};
ATTRIBUTE_GROUPS(mmc_dev);

-/*
- * This currently matches any MMC driver to any MMC card - drivers
- * themselves make the decision whether to drive this card in their
- * probe method.
- */
-static int mmc_bus_match(struct device *dev, struct device_driver *drv)
-{
- return 1;
-}
-
static int
mmc_bus_uevent(struct device *dev, struct kobj_uevent_env *env)
{
@@ -226,7 +216,6 @@ static const struct dev_pm_ops mmc_bus_pm_ops = {
static struct bus_type mmc_bus_type = {
.name = "mmc",
.dev_groups = mmc_dev_groups,
- .match = mmc_bus_match,
.uevent = mmc_bus_uevent,
.probe = mmc_bus_probe,
.remove = mmc_bus_remove,
--
2.25.1

2021-12-09 12:57:07

by Ulf Hansson

Subject: Re: [PATCH] drivers/mmc/core/bus: Remove redundant driver match function

On Thu, 9 Dec 2021 at 13:02, lizhe <[email protected]> wrote:
>
> If there is no driver match function, the driver core assumes
> that each candidate pair (driver, device) matches. See function
> driver_match_device().
>
> Drop the mmc bus's match function that always returned 1 and
> so implements the same behaviour as when there is no match
> function.
>
> Signed-off-by: lizhe <[email protected]>

I have already applied your previous version. Or is there a change in
this version?

Future wise, please bump the version number between each submission
and highlight what you have changed. See
Documentation/SubmittingPatches.

Kind regards
Uffe


> ---
> drivers/mmc/core/bus.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index f6b7a9c5bbff..096ae624be9a 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -53,16 +53,6 @@ static struct attribute *mmc_dev_attrs[] = {
> };
> ATTRIBUTE_GROUPS(mmc_dev);
>
> -/*
> - * This currently matches any MMC driver to any MMC card - drivers
> - * themselves make the decision whether to drive this card in their
> - * probe method.
> - */
> -static int mmc_bus_match(struct device *dev, struct device_driver *drv)
> -{
> - return 1;
> -}
> -
> static int
> mmc_bus_uevent(struct device *dev, struct kobj_uevent_env *env)
> {
> @@ -226,7 +216,6 @@ static const struct dev_pm_ops mmc_bus_pm_ops = {
> static struct bus_type mmc_bus_type = {
> .name = "mmc",
> .dev_groups = mmc_dev_groups,
> - .match = mmc_bus_match,
> .uevent = mmc_bus_uevent,
> .probe = mmc_bus_probe,
> .remove = mmc_bus_remove,
> --
> 2.25.1
>
>