2024-02-08 20:22:25

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn

Use existing typedef for dma_filter_fn to avoid duplicating type
definition.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/mmc/host/renesas_sdhi.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
index c1fb9740eab0..586f94d4dbfd 100644
--- a/drivers/mmc/host/renesas_sdhi.h
+++ b/drivers/mmc/host/renesas_sdhi.h
@@ -9,6 +9,7 @@
#ifndef RENESAS_SDHI_H
#define RENESAS_SDHI_H

+#include <linux/dmaengine.h>
#include <linux/platform_device.h>
#include "tmio_mmc.h"

@@ -63,7 +64,7 @@ struct renesas_sdhi_of_data_with_quirks {
struct renesas_sdhi_dma {
unsigned long end_flags;
enum dma_slave_buswidth dma_buswidth;
- bool (*filter)(struct dma_chan *chan, void *arg);
+ dma_filter_fn filter;
void (*enable)(struct tmio_mmc_host *host, bool enable);
struct completion dma_dataend;
struct tasklet_struct dma_complete;
--
2.34.1



2024-02-09 00:10:58

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn

On Thu, Feb 08, 2024 at 09:21:37PM +0100, Krzysztof Kozlowski wrote:
> Use existing typedef for dma_filter_fn to avoid duplicating type
> definition.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Wolfram Sang <[email protected]>

Attachments:
(No filename) (294.00 B)
 signature.asc (849.00 B)
 Download all attachments

2024-02-13 17:09:22

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH] mmc: renesas_sdhi: use typedef for dma_filter_fn

On Thu, 8 Feb 2024 at 21:21, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Use existing typedef for dma_filter_fn to avoid duplicating type
> definition.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/renesas_sdhi.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h
> index c1fb9740eab0..586f94d4dbfd 100644
> --- a/drivers/mmc/host/renesas_sdhi.h
> +++ b/drivers/mmc/host/renesas_sdhi.h
> @@ -9,6 +9,7 @@
> #ifndef RENESAS_SDHI_H
> #define RENESAS_SDHI_H
>
> +#include <linux/dmaengine.h>
> #include <linux/platform_device.h>
> #include "tmio_mmc.h"
>
> @@ -63,7 +64,7 @@ struct renesas_sdhi_of_data_with_quirks {
> struct renesas_sdhi_dma {
> unsigned long end_flags;
> enum dma_slave_buswidth dma_buswidth;
> - bool (*filter)(struct dma_chan *chan, void *arg);
> + dma_filter_fn filter;
> void (*enable)(struct tmio_mmc_host *host, bool enable);
> struct completion dma_dataend;
> struct tasklet_struct dma_complete;
> --
> 2.34.1
>