2024-01-29 17:48:31

by André Draszik

Subject: [PATCH v3 7/7] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole

This bus has three USB-related devices attached to it:
0x25: Maxim 77759 Type-C port controller
0x35: Maxim 20339EWB Surge protection IC
0x36: Maxim 77759 Fuel gauge
0x57: NXP PCA9468 Battery charger
0x66: Maxim 77759 PMIC
0x69: Maxim 77759 Charger
where the Maxim 77759 has multiple i2c slave addresses.

These don't have (upstream) Linux drivers yet, but nevertheless we can
enable the bus so as to allow working on them (and to make i2cdetect /
i2cdump / etc. work).

Signed-off-by: André Draszik <[email protected]>
Reviewed-by: Peter Griffin <[email protected]>

---
v2:
* add short summary of devices attached to this bus & add TODO
* collect Reviewed-by: tags
---
arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
index cb4d17339b6b..6ccade2c8cb4 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
+++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
@@ -72,6 +72,11 @@ eeprom: eeprom@50 {
};
};

+&hsi2c_12 {
+ status = "okay";
+ /* TODO: add the devices once drivers exist */
+};
+
&pinctrl_far_alive {
key_voldown: key-voldown-pins {
samsung,pins = "gpa7-3";
@@ -113,6 +118,11 @@ &usi8 {
status = "okay";
};

+&usi12 {
+ samsung,mode = <USI_V2_I2C>;
+ status = "okay";
+};
+
&watchdog_cl0 {
timeout-sec = <30>;
status = "okay";
--
2.43.0.429.g432eaa2c6b-goog

2024-01-29 19:21:53

by Sam Protsenko

Subject: Re: [PATCH v3 7/7] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole

On Mon, Jan 29, 2024 at 11:47 AM André Draszik <[email protected]> wrote:
>
> This bus has three USB-related devices attached to it:
> 0x25: Maxim 77759 Type-C port controller
> 0x35: Maxim 20339EWB Surge protection IC
> 0x36: Maxim 77759 Fuel gauge
> 0x57: NXP PCA9468 Battery charger
> 0x66: Maxim 77759 PMIC
> 0x69: Maxim 77759 Charger
> where the Maxim 77759 has multiple i2c slave addresses.
>
> These don't have (upstream) Linux drivers yet, but nevertheless we can
> enable the bus so as to allow working on them (and to make i2cdetect /
> i2cdump / etc. work).
>
> Signed-off-by: André Draszik <[email protected]>
> Reviewed-by: Peter Griffin <[email protected]>
>
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> v2:
> * add short summary of devices attached to this bus & add TODO
> * collect Reviewed-by: tags
> ---
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index cb4d17339b6b..6ccade2c8cb4 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -72,6 +72,11 @@ eeprom: eeprom@50 {
> };
> };
>
> +&hsi2c_12 {
> + status = "okay";
> + /* TODO: add the devices once drivers exist */
> +};
> +
> &pinctrl_far_alive {
> key_voldown: key-voldown-pins {
> samsung,pins = "gpa7-3";
> @@ -113,6 +118,11 @@ &usi8 {
> status = "okay";
> };
>
> +&usi12 {
> + samsung,mode = <USI_V2_I2C>;
> + status = "okay";
> +};
> +
> &watchdog_cl0 {
> timeout-sec = <30>;
> status = "okay";
> --
> 2.43.0.429.g432eaa2c6b-goog
>

2024-01-30 09:22:24

by Tudor Ambarus

Subject: Re: [PATCH v3 7/7] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole

On 1/29/24 17:46, André Draszik wrote:
> This bus has three USB-related devices attached to it:
> 0x25: Maxim 77759 Type-C port controller
> 0x35: Maxim 20339EWB Surge protection IC
> 0x36: Maxim 77759 Fuel gauge
> 0x57: NXP PCA9468 Battery charger
> 0x66: Maxim 77759 PMIC
> 0x69: Maxim 77759 Charger
> where the Maxim 77759 has multiple i2c slave addresses.
>
> These don't have (upstream) Linux drivers yet, but nevertheless we can
> enable the bus so as to allow working on them (and to make i2cdetect /
> i2cdump / etc. work).
>
> Signed-off-by: André Draszik <[email protected]>
> Reviewed-by: Peter Griffin <[email protected]>

Reviewed-by: Tudor Ambarus <[email protected]>
>
> ---
> v2:
> * add short summary of devices attached to this bus & add TODO
> * collect Reviewed-by: tags
> ---
> arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index cb4d17339b6b..6ccade2c8cb4 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -72,6 +72,11 @@ eeprom: eeprom@50 {
> };
> };
>
> +&hsi2c_12 {
> + status = "okay";
> + /* TODO: add the devices once drivers exist */
> +};
> +
> &pinctrl_far_alive {
> key_voldown: key-voldown-pins {
> samsung,pins = "gpa7-3";
> @@ -113,6 +118,11 @@ &usi8 {
> status = "okay";
> };
>
> +&usi12 {
> + samsung,mode = <USI_V2_I2C>;
> + status = "okay";
> +};
> +
> &watchdog_cl0 {
> timeout-sec = <30>;
> status = "okay";