2022-02-11 17:54:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: soc: samsung: usi: refer to dtschema for children

Explicitly reference the dtschema for USI children implementing specific
serial protocol (I2C, SPI, UART). The SPI schema is not yet accepted,
so it will be provided later.

Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes since v1:
1. Drop entire paragraph about USI nodes.
---
.../bindings/soc/samsung/exynos-usi.yaml | 20 +++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
index 58f2e9d8bb0e..a98ed66d092e 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
@@ -17,13 +17,6 @@ description: |
child nodes, each representing a serial sub-node device. The mode setting
selects which particular function will be used.

- Refer to next bindings documentation for information on protocol subnodes that
- can exist under USI node:
-
- [1] Documentation/devicetree/bindings/serial/samsung_uart.yaml
- [2] Documentation/devicetree/bindings/i2c/i2c-exynos5.txt
- [3] Documentation/devicetree/bindings/spi/spi-samsung.txt
-
properties:
$nodename:
pattern: "^usi@[0-9a-f]+$"
@@ -75,10 +68,17 @@ properties:
This property is optional.

patternProperties:
- # All other properties should be child nodes
- "^(serial|spi|i2c)@[0-9a-f]+$":
+ "^i2c@[0-9a-f]+$":
+ $ref: /schemas/i2c/i2c-exynos5.yaml
+ description: Child node describing underlying I2C
+
+ "^serial@[0-9a-f]+$":
+ $ref: /schemas/serial/samsung_uart.yaml
+ description: Child node describing underlying UART/serial
+
+ "^spi@[0-9a-f]+$":
type: object
- description: Child node describing underlying USI serial protocol
+ description: Child node describing underlying SPI

required:
- compatible
--
2.32.0


2022-02-12 18:23:04

by Sam Protsenko

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: soc: samsung: usi: refer to dtschema for children

On Fri, 11 Feb 2022 at 18:47, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Explicitly reference the dtschema for USI children implementing specific
> serial protocol (I2C, SPI, UART). The SPI schema is not yet accepted,
> so it will be provided later.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. Drop entire paragraph about USI nodes.
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> .../bindings/soc/samsung/exynos-usi.yaml | 20 +++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> index 58f2e9d8bb0e..a98ed66d092e 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -17,13 +17,6 @@ description: |
> child nodes, each representing a serial sub-node device. The mode setting
> selects which particular function will be used.
>
> - Refer to next bindings documentation for information on protocol subnodes that
> - can exist under USI node:
> -
> - [1] Documentation/devicetree/bindings/serial/samsung_uart.yaml
> - [2] Documentation/devicetree/bindings/i2c/i2c-exynos5.txt
> - [3] Documentation/devicetree/bindings/spi/spi-samsung.txt
> -
> properties:
> $nodename:
> pattern: "^usi@[0-9a-f]+$"
> @@ -75,10 +68,17 @@ properties:
> This property is optional.
>
> patternProperties:
> - # All other properties should be child nodes
> - "^(serial|spi|i2c)@[0-9a-f]+$":
> + "^i2c@[0-9a-f]+$":
> + $ref: /schemas/i2c/i2c-exynos5.yaml
> + description: Child node describing underlying I2C
> +
> + "^serial@[0-9a-f]+$":
> + $ref: /schemas/serial/samsung_uart.yaml
> + description: Child node describing underlying UART/serial
> +
> + "^spi@[0-9a-f]+$":
> type: object
> - description: Child node describing underlying USI serial protocol
> + description: Child node describing underlying SPI
>
> required:
> - compatible
> --
> 2.32.0
>

2022-02-14 18:51:00

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: soc: samsung: usi: refer to dtschema for children

On Fri, 11 Feb 2022 17:47:16 +0100, Krzysztof Kozlowski wrote:
> Explicitly reference the dtschema for USI children implementing specific
> serial protocol (I2C, SPI, UART). The SPI schema is not yet accepted,
> so it will be provided later.
>
>

Applied, thanks!

[1/1] dt-bindings: soc: samsung: usi: refer to dtschema for children
commit: e465ea5cc05d1d0b45c315fca0254bd2ee04b661

Best regards,
--
Krzysztof Kozlowski <[email protected]>