2021-10-06 13:26:52

by Krzysztof Kozlowski

Subject: [PATCH v3 10/10] dt-bindings: mfd: samsung,s5m8767: document buck and LDO supplies

Document the properties with regulator supplies for bucks and LDOs. At
least one board uses it (Exynos5250 Arndale).

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
index b2529a48c890..12dea5aac8b6 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
+++ b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
@@ -96,6 +96,44 @@ properties:
description: |
GPIO specifiers for three host gpio's used for dvs.

+ vinb1-supply:
+ description: Power supply for buck1
+ vinb2-supply:
+ description: Power supply for buck1
+ vinb3-supply:
+ description: Power supply for buck1
+ vinb4-supply:
+ description: Power supply for buck1
+ vinb5-supply:
+ description: Power supply for buck1
+ vinb6-supply:
+ description: Power supply for buck1
+ vinb7-supply:
+ description: Power supply for buck1
+ vinb8-supply:
+ description: Power supply for buck1
+ vinb9-supply:
+ description: Power supply for buck1
+
+ vinl1-supply:
+ description: Power supply for LDO3, LDO10, LDO26, LDO27
+ vinl2-supply:
+ description: Power supply for LDO13, LDO16, LDO25, LDO28
+ vinl3-supply:
+ description: Power supply for LDO11, LDO14
+ vinl4-supply:
+ description: Power supply for LDO4, LDO9
+ vinl5-supply:
+ description: Power supply for LDO12, LDO17, LDO19, LDO23
+ vinl6-supply:
+ description: Power supply for LDO18, LDO20, LDO21, LDO24
+ vinl7-supply:
+ description: Power supply for LDO5, LDO22
+ vinl8-supply:
+ description: Power supply for LDO1, LDO6, LDO7, LDO8, LDO15
+ vinl9-supply:
+ description: Power supply for LDO2
+
wakeup-source: true

required:
--
2.30.2

2021-10-06 20:03:44

by Sam Protsenko

Subject: Re: [PATCH v3 10/10] dt-bindings: mfd: samsung,s5m8767: document buck and LDO supplies

On Wed, 6 Oct 2021 at 16:24, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Document the properties with regulator supplies for bucks and LDOs. At
> least one board uses it (Exynos5250 Arndale).
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
> index b2529a48c890..12dea5aac8b6 100644
> --- a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
> +++ b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
> @@ -96,6 +96,44 @@ properties:
> description: |
> GPIO specifiers for three host gpio's used for dvs.
>
> + vinb1-supply:
> + description: Power supply for buck1
> + vinb2-supply:
> + description: Power supply for buck1

Nitpick: all those vinb* are for buck1, or that's a typo (here and below)?

> + vinb3-supply:
> + description: Power supply for buck1
> + vinb4-supply:
> + description: Power supply for buck1
> + vinb5-supply:
> + description: Power supply for buck1
> + vinb6-supply:
> + description: Power supply for buck1
> + vinb7-supply:
> + description: Power supply for buck1
> + vinb8-supply:
> + description: Power supply for buck1
> + vinb9-supply:
> + description: Power supply for buck1
> +
> + vinl1-supply:
> + description: Power supply for LDO3, LDO10, LDO26, LDO27
> + vinl2-supply:
> + description: Power supply for LDO13, LDO16, LDO25, LDO28
> + vinl3-supply:
> + description: Power supply for LDO11, LDO14
> + vinl4-supply:
> + description: Power supply for LDO4, LDO9
> + vinl5-supply:
> + description: Power supply for LDO12, LDO17, LDO19, LDO23
> + vinl6-supply:
> + description: Power supply for LDO18, LDO20, LDO21, LDO24
> + vinl7-supply:
> + description: Power supply for LDO5, LDO22
> + vinl8-supply:
> + description: Power supply for LDO1, LDO6, LDO7, LDO8, LDO15
> + vinl9-supply:
> + description: Power supply for LDO2
> +
> wakeup-source: true
>
> required:
> --
> 2.30.2
>

2021-10-07 19:27:32

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 10/10] dt-bindings: mfd: samsung,s5m8767: document buck and LDO supplies

On 06/10/2021 22:02, Sam Protsenko wrote:
> On Wed, 6 Oct 2021 at 16:24, Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> Document the properties with regulator supplies for bucks and LDOs. At
>> least one board uses it (Exynos5250 Arndale).
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> Reviewed-by: Rob Herring <[email protected]>
>> ---
>> .../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++
>> 1 file changed, 38 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
>> index b2529a48c890..12dea5aac8b6 100644
>> --- a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml
>> @@ -96,6 +96,44 @@ properties:
>> description: |
>> GPIO specifiers for three host gpio's used for dvs.
>>
>> + vinb1-supply:
>> + description: Power supply for buck1
>> + vinb2-supply:
>> + description: Power supply for buck1
>
> Nitpick: all those vinb* are for buck1, or that's a typo (here and below)?

Copy paste and needs fixing. Thanks for checking.

>
>> + vinb3-supply:
>> + description: Power supply for buck1
>> + vinb4-supply:
>> + description: Power supply for buck1
>> + vinb5-supply:
>> + description: Power supply for buck1
>> + vinb6-supply:
>> + description: Power supply for buck1
>> + vinb7-supply:
>> + description: Power supply for buck1
>> + vinb8-supply:
>> + description: Power supply for buck1
>> + vinb9-supply:
>> + description: Power supply for buck1
>> +

Best regards,
Krzysztof