2024-01-10 10:27:57

by Tudor Ambarus

Subject: [PATCH 09/18] tty: serial: samsung: drop superfluous comment

The comment brings no benefit as we can already see from the method's
name, ``s3c24xx_serial_pm``, that it deals with power management.
Drop the superfluous comment.

Signed-off-by: Tudor Ambarus <[email protected]>
---
drivers/tty/serial/samsung_tty.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index b9d1ef67468c..90c49197efc7 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -1296,8 +1296,6 @@ static int apple_s5l_serial_startup(struct uart_port *port)
return ret;
}

-/* power power management control */
-
static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
unsigned int old)
{
--
2.43.0.472.g3155946c3a-goog

2024-01-16 18:19:09

by Sam Protsenko

Subject: Re: [PATCH 09/18] tty: serial: samsung: drop superfluous comment

On Wed, Jan 10, 2024 at 4:23 AM Tudor Ambarus <tudor.ambarus@linaroorg> wrote:
>
> The comment brings no benefit as we can already see from the method's
> name, ``s3c24xx_serial_pm``, that it deals with power management.
> Drop the superfluous comment.
>
> Signed-off-by: Tudor Ambarus <[email protected]>
> ---

Reviewed-by: Sam Protsenko <[email protected]>

> drivers/tty/serial/samsung_tty.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index b9d1ef67468c..90c49197efc7 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -1296,8 +1296,6 @@ static int apple_s5l_serial_startup(struct uart_port *port)
> return ret;
> }
>
> -/* power power management control */
> -
> static void s3c24xx_serial_pm(struct uart_port *port, unsigned int level,
> unsigned int old)
> {
> --
> 2.43.0.472.g3155946c3a-goog
>
>