Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
leaves unnecessary empty braces. Remove those to fix the style. No
functional change.
Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
Signed-off-by: Sam Protsenko <[email protected]>
---
drivers/tty/serial/samsung_tty.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
index fcc675603b14..23cabdab44ff 100644
--- a/drivers/tty/serial/samsung_tty.c
+++ b/drivers/tty/serial/samsung_tty.c
@@ -2452,7 +2452,7 @@ static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
#endif
#if defined(CONFIG_ARCH_EXYNOS)
-#define EXYNOS_COMMON_SERIAL_DRV_DATA() \
+#define EXYNOS_COMMON_SERIAL_DRV_DATA \
.info = { \
.name = "Samsung Exynos UART", \
.type = TYPE_S3C6400, \
@@ -2477,17 +2477,17 @@ static const struct s3c24xx_serial_drv_data s5pv210_serial_drv_data = {
} \
static const struct s3c24xx_serial_drv_data exynos4210_serial_drv_data = {
- EXYNOS_COMMON_SERIAL_DRV_DATA(),
+ EXYNOS_COMMON_SERIAL_DRV_DATA,
.fifosize = { 256, 64, 16, 16 },
};
static const struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = {
- EXYNOS_COMMON_SERIAL_DRV_DATA(),
+ EXYNOS_COMMON_SERIAL_DRV_DATA,
.fifosize = { 64, 256, 16, 256 },
};
static const struct s3c24xx_serial_drv_data exynos850_serial_drv_data = {
- EXYNOS_COMMON_SERIAL_DRV_DATA(),
+ EXYNOS_COMMON_SERIAL_DRV_DATA,
.fifosize = { 256, 64, 64, 64 },
};
--
2.39.2
On 02/02/2024 02:05, Sam Protsenko wrote:
> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
> leaves unnecessary empty braces. Remove those to fix the style. No
> functional change.
>
> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> Signed-off-by: Sam Protsenko <[email protected]>
> ---
> drivers/tty/serial/samsung_tty.c | 8 ++++----
I am pretty sure you did the patch on some old tree, not mainline rc1.
Please work on maintainers tree (or linux-next).
Best regards,
Krzysztof
On Fri, Feb 2, 2024 at 1:49 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 02/02/2024 02:05, Sam Protsenko wrote:
> > Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> > removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
> > leaves unnecessary empty braces. Remove those to fix the style. No
> > functional change.
> >
> > Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> > Signed-off-by: Sam Protsenko <[email protected]>
> > ---
> > drivers/tty/serial/samsung_tty.c | 8 ++++----
>
> I am pretty sure you did the patch on some old tree, not mainline rc1.
> Please work on maintainers tree (or linux-next).
>
Hi Krzysztof,
I worked on linux-next, and rebased it on top of the latest linux-next
yesterday, right before submitting. I distinctly remember solving a
conflict while rebasing, due to the new commit 0b87a9fd670a ("tty:
serial: samsung: set UPIO_MEM32 iotype for gs101") which just got into
linux-next yesterday. Please let me know if you want me to rebase it
on another tree and re-submit.
Thanks!
> Best regards,
> Krzysztof
>
On 02/02/2024 15:54, Sam Protsenko wrote:
> On Fri, Feb 2, 2024 at 1:49 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 02/02/2024 02:05, Sam Protsenko wrote:
>>> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>>> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
>>> leaves unnecessary empty braces. Remove those to fix the style. No
>>> functional change.
>>>
>>> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>>> Signed-off-by: Sam Protsenko <[email protected]>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 8 ++++----
>>
>> I am pretty sure you did the patch on some old tree, not mainline rc1.
>> Please work on maintainers tree (or linux-next).
>>
>
> Hi Krzysztof,
>
> I worked on linux-next, and rebased it on top of the latest linux-next
> yesterday, right before submitting. I distinctly remember solving a
> conflict while rebasing, due to the new commit 0b87a9fd670a ("tty:
> serial: samsung: set UPIO_MEM32 iotype for gs101") which just got into
> linux-next yesterday. Please let me know if you want me to rebase it
> on another tree and re-submit.
>
Hmm... Almost two months ago GS101 was applied which also uses
EXYNOS_COMMON_SERIAL_DRV_DATA, so should be in the hunks here, but
maybye it's gone now?
Best regards,
Krzysztof
On 02/02/2024 08:49, Krzysztof Kozlowski wrote:
> On 02/02/2024 02:05, Sam Protsenko wrote:
>> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
>> leaves unnecessary empty braces. Remove those to fix the style. No
>> functional change.
>>
>> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>> Signed-off-by: Sam Protsenko <[email protected]>
>> ---
>> drivers/tty/serial/samsung_tty.c | 8 ++++----
>
> I am pretty sure you did the patch on some old tree, not mainline rc1.
> Please work on maintainers tree (or linux-next).
My bad, Tudor's patchset changed it few days ago and I missed that it
was applied.
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Thu, Feb 01, 2024 at 07:05:07PM -0600, Sam Protsenko wrote:
> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
> leaves unnecessary empty braces. Remove those to fix the style. No
> functional change.
>
> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
"no functional change" don't really deserve a "Fixes:" tag. I'll go
delete this when applying, thanks.
greg k-h