2023-09-25 09:05:40

by Dave Airlie

[permalink] [raw]
Subject: Re: [PATCH v6 04/20] drm/imagination/uapi: Add PowerVR driver UAPI

> +struct drm_pvr_dev_query_gpu_info {
> + /**
> + * @gpu_id: GPU identifier.
> + *
> + * For all currently supported GPUs this is the BVNC encoded as a 64-bit
> + * value as follows:
> + *
> + * +--------+--------+--------+-------+
> + * | 63..48 | 47..32 | 31..16 | 15..0 |
> + * +========+========+========+=======+
> + * | B | V | N | C |
> + * +--------+--------+--------+-------+
> + */
> + __u64 gpu_id;
> +
> + /**
> + * @num_phantoms: Number of Phantoms present.
> + */
> + __u32 num_phantoms;
> +};

I think this one needs __u32 padding; of some sort.

Dave.