Hi,
I've been working on the correcting the checkpatch.pl failures found in
staging/drivers/staging/comedi of 4.18.0 and have a few patches to submit
for review.
The files that I changed are:
drivers/dt3000.c
drivers/ni_labpc_common.c
drivers/ni_mio_common.c
drivers/dt3000.c
While there were a few warnings/checks checkpatch.pl brings up the only
one that the Internet told me was ok to work on were dereferences that
happened over multiple lines. For each of the files above that was the issue
and it was always due to the author trying to stay within the 80 character
line width limitation. I did my best to remove the warning while keeping the
code readable.
**PLEASE**: any feedback on what I could do better in the patches, in the
emails, anything, would be much appreciated.
Thanks so much!
Ray
---
drivers/staging/comedi/drivers/dt3000.c | 6 +++---
drivers/staging/comedi/drivers/ni_labpc_common.c | 8 ++++----
drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---
drivers/staging/comedi/drivers/rtd520.c | 6 +++---
4 files changed, 13 insertions(+), 13 deletions(-)
On Thu, Aug 30, 2018 at 01:32:09PM -0400, Ray Clinton wrote:
> Hi,
>
> I've been working on the correcting the checkpatch.pl failures found in
> staging/drivers/staging/comedi of 4.18.0 and have a few patches to submit
> for review.
>
> The files that I changed are:
>
> drivers/dt3000.c
> drivers/ni_labpc_common.c
> drivers/ni_mio_common.c
> drivers/dt3000.c
>
> While there were a few warnings/checks checkpatch.pl brings up the only
> one that the Internet told me was ok to work on were dereferences that
> happened over multiple lines. For each of the files above that was the issue
> and it was always due to the author trying to stay within the 80 character
> line width limitation. I did my best to remove the warning while keeping the
> code readable.
>
> **PLEASE**: any feedback on what I could do better in the patches, in the
> emails, anything, would be much appreciated.
You sent 4 patches with the identical Subject: line, which isn't
something that I can apply. Please make the subjects unique, as they
all do unique things, right?
thanks,
greg k-h