2013-05-27 07:58:45

by Runzhen Wang

Subject: [PATCH] perf tools: fix a wrong header file path in util/unwind.c

For the latest perf core tree:
(git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git),
in util/unwind.c line 29 includes "perf_regs.h". That means compiler
will search for this header file in current directory, so, gcc will
puts the following error messages:

util/unwind.c: In function ‘access_mem’:
util/unwind.c:400:50: error: ‘PERF_REG_SP’ undeclared (first use in this
function)
util/unwind.c:400:50: note: each undeclared identifier is reported only
once for each function it appears in
util/unwind.c: In function ‘unwind__get_entries’:
util/unwind.c:562:41: error: ‘PERF_REG_IP’ undeclared (first use in this
function)

Changing #include "perf_regs.h" to #include <perf_regs.h> will fix the
error.

Signed-off-by: Runzhen Wang <[email protected]>
---
tools/perf/util/unwind.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/unwind.c b/tools/perf/util/unwind.c
index 958723b..50e14f7 100644
--- a/tools/perf/util/unwind.c
+++ b/tools/perf/util/unwind.c
@@ -26,7 +26,7 @@
#include <libunwind-ptrace.h>
#include "thread.h"
#include "session.h"
-#include "perf_regs.h"
+#include <perf_regs.h>
#include "unwind.h"
#include "util.h"

--
1.7.9.5

2013-05-27 08:15:03

by Runzhen Wang

Subject: Re: [PATCH] perf tools: fix a wrong header file path in util/unwind.c

Sorry, I made a mistake.....
There is no bug, please ignore my patch.
Sorry again. I will be careful next time.

On Mon, May 27, 2013 at 3:54 PM, Runzhen Wang <[email protected]> wrote:
> For the latest perf core tree:
> (git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git),
> in util/unwind.c line 29 includes "perf_regs.h". That means compiler
> will search for this header file in current directory, so, gcc will
> puts the following error messages:
>
> util/unwind.c: In function ?access_mem?:
> util/unwind.c:400:50: error: ?PERF_REG_SP? undeclared (first use in this
> function)
> util/unwind.c:400:50: note: each undeclared identifier is reported only
> once for each function it appears in
> util/unwind.c: In function ?unwind__get_entries?:
> util/unwind.c:562:41: error: ?PERF_REG_IP? undeclared (first use in this
> function)
>
> Changing #include "perf_regs.h" to #include <perf_regs.h> will fix the
> error.
>
> Signed-off-by: Runzhen Wang <[email protected]>
> ---
> tools/perf/util/unwind.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/unwind.c b/tools/perf/util/unwind.c
> index 958723b..50e14f7 100644
> --- a/tools/perf/util/unwind.c
> +++ b/tools/perf/util/unwind.c
> @@ -26,7 +26,7 @@
> #include <libunwind-ptrace.h>
> #include "thread.h"
> #include "session.h"
> -#include "perf_regs.h"
> +#include <perf_regs.h>
> #include "unwind.h"
> #include "util.h"
>
> --
> 1.7.9.5
>