2020-09-03 14:24:14

by Enric Balletbo i Serra

[permalink] [raw]
Subject: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config

The MFD_CROS_EC config was a transitional Kconfig option to not break
current defconfigs in the kernel. Now, this is not required anymore
because all the defconfigs have been removed this option and migrated to
enable the CrOS EC parts individually.

Signed-off-by: Enric Balletbo i Serra <[email protected]>
---

drivers/platform/chrome/Kconfig | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
index a056031dee81..ccc23d8686e8 100644
--- a/drivers/platform/chrome/Kconfig
+++ b/drivers/platform/chrome/Kconfig
@@ -3,16 +3,6 @@
# Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
#

-config MFD_CROS_EC
- tristate "Platform support for Chrome hardware (transitional)"
- select CHROME_PLATFORMS
- select CROS_EC
- select MFD_CROS_EC_DEV
- depends on X86 || ARM || ARM64 || COMPILE_TEST
- help
- This is a transitional Kconfig option and will be removed after
- everyone enables the parts individually.
-
menuconfig CHROME_PLATFORMS
bool "Platform support for Chrome hardware"
depends on X86 || ARM || ARM64 || COMPILE_TEST
--
2.28.0


2020-09-03 15:06:44

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config

On Thu, Sep 3, 2020 at 7:17 AM Enric Balletbo i Serra
<[email protected]> wrote:
>
> The MFD_CROS_EC config was a transitional Kconfig option to not break
> current defconfigs in the kernel. Now, this is not required anymore
> because all the defconfigs have been removed this option and migrated to
> enable the CrOS EC parts individually.
>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
>
> drivers/platform/chrome/Kconfig | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index a056031dee81..ccc23d8686e8 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -3,16 +3,6 @@
> # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
> #
>
> -config MFD_CROS_EC
> - tristate "Platform support for Chrome hardware (transitional)"
> - select CHROME_PLATFORMS
> - select CROS_EC
> - select MFD_CROS_EC_DEV
> - depends on X86 || ARM || ARM64 || COMPILE_TEST
> - help
> - This is a transitional Kconfig option and will be removed after
> - everyone enables the parts individually.
> -
> menuconfig CHROME_PLATFORMS
> bool "Platform support for Chrome hardware"
> depends on X86 || ARM || ARM64 || COMPILE_TEST
> --
> 2.28.0
>

2020-09-03 20:40:38

by Gwendal Grignou

[permalink] [raw]
Subject: Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config

On Thu, Sep 3, 2020 at 8:02 AM Guenter Roeck <[email protected]> wrote:
>
> On Thu, Sep 3, 2020 at 7:17 AM Enric Balletbo i Serra
> <[email protected]> wrote:
> >
> > The MFD_CROS_EC config was a transitional Kconfig option to not break
> > current defconfigs in the kernel. Now, this is not required anymore
> > because all the defconfigs have been removed this option and migrated to
> > enable the CrOS EC parts individually.
> >
> > Signed-off-by: Enric Balletbo i Serra <[email protected]>
>
> Reviewed-by: Guenter Roeck <[email protected]>
Tested-by: Gwendal Grignou <[email protected]>
>
> > ---
> >
> > drivers/platform/chrome/Kconfig | 10 ----------
> > 1 file changed, 10 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> > index a056031dee81..ccc23d8686e8 100644
> > --- a/drivers/platform/chrome/Kconfig
> > +++ b/drivers/platform/chrome/Kconfig
> > @@ -3,16 +3,6 @@
> > # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
> > #
> >
> > -config MFD_CROS_EC
> > - tristate "Platform support for Chrome hardware (transitional)"
> > - select CHROME_PLATFORMS
> > - select CROS_EC
> > - select MFD_CROS_EC_DEV
> > - depends on X86 || ARM || ARM64 || COMPILE_TEST
> > - help
> > - This is a transitional Kconfig option and will be removed after
> > - everyone enables the parts individually.
> > -
> > menuconfig CHROME_PLATFORMS
> > bool "Platform support for Chrome hardware"
> > depends on X86 || ARM || ARM64 || COMPILE_TEST
> > --
> > 2.28.0
> >

2020-09-07 13:41:01

by Enric Balletbo i Serra

[permalink] [raw]
Subject: Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config

Hi Gwendal and Guenter,

Thank you for the review and tested tags.

On 3/9/20 16:17, Enric Balletbo i Serra wrote:
> The MFD_CROS_EC config was a transitional Kconfig option to not break
> current defconfigs in the kernel. Now, this is not required anymore
> because all the defconfigs have been removed this option and migrated to
> enable the CrOS EC parts individually.
>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>

Applied for 5.10

Thanks,
Enric

> ---
>
> drivers/platform/chrome/Kconfig | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig
> index a056031dee81..ccc23d8686e8 100644
> --- a/drivers/platform/chrome/Kconfig
> +++ b/drivers/platform/chrome/Kconfig
> @@ -3,16 +3,6 @@
> # Platform support for Chrome OS hardware (Chromebooks and Chromeboxes)
> #
>
> -config MFD_CROS_EC
> - tristate "Platform support for Chrome hardware (transitional)"
> - select CHROME_PLATFORMS
> - select CROS_EC
> - select MFD_CROS_EC_DEV
> - depends on X86 || ARM || ARM64 || COMPILE_TEST
> - help
> - This is a transitional Kconfig option and will be removed after
> - everyone enables the parts individually.
> -
> menuconfig CHROME_PLATFORMS
> bool "Platform support for Chrome hardware"
> depends on X86 || ARM || ARM64 || COMPILE_TEST
>