2020-07-08 14:48:34

by Maxime Ripard

[permalink] [raw]
Subject: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component

Since the components for a given device in ASoC are identified by their
name, it makes sense to add one even though it's not strictly necessary.

Signed-off-by: Maxime Ripard <[email protected]>
---
drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 15a11cd4de25..a057db0d9baa 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -983,6 +983,7 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
};

static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
+ .name = "vc4-hdmi-codec-dai-component",
.controls = vc4_hdmi_audio_controls,
.num_controls = ARRAY_SIZE(vc4_hdmi_audio_controls),
.dapm_widgets = vc4_hdmi_audio_widgets,
--
2.26.2


2020-10-29 08:11:39

by Dave Stevenson

[permalink] [raw]
Subject: Re: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component

Hi Maxime

On Wed, 8 Jul 2020 at 15:46, Maxime Ripard <[email protected]> wrote:
>
> Since the components for a given device in ASoC are identified by their
> name, it makes sense to add one even though it's not strictly necessary.
>
> Signed-off-by: Maxime Ripard <[email protected]>

Reviewed-by: Dave Stevenson <[email protected]>

> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 15a11cd4de25..a057db0d9baa 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -983,6 +983,7 @@ static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
> };
>
> static const struct snd_soc_component_driver vc4_hdmi_audio_component_drv = {
> + .name = "vc4-hdmi-codec-dai-component",
> .controls = vc4_hdmi_audio_controls,
> .num_controls = ARRAY_SIZE(vc4_hdmi_audio_controls),
> .dapm_widgets = vc4_hdmi_audio_widgets,
> --
> 2.26.2
>

2020-10-29 09:31:14

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] drm/vc4: hdmi: Add a name to the codec DAI component

On Wed, Oct 28, 2020 at 01:30:32PM +0000, Dave Stevenson wrote:
> Hi Maxime
>
> On Wed, 8 Jul 2020 at 15:46, Maxime Ripard <[email protected]> wrote:
> >
> > Since the components for a given device in ASoC are identified by their
> > name, it makes sense to add one even though it's not strictly necessary.
> >
> > Signed-off-by: Maxime Ripard <[email protected]>
>
> Reviewed-by: Dave Stevenson <[email protected]>

Applied, thanks!
Maxime


Attachments:
(No filename) (470.00 B)
signature.asc (235.00 B)
Download all attachments