2023-01-10 23:48:19

by Rob Clark

Subject: [PATCH v2 0/3] drm/msm/gpu: Devfreq fixes+tuning

From: Rob Clark <[email protected]>

Rob Clark (3):
drm/msm/gpu: Add devfreq tuning debugfs
drm/msm/gpu: Bypass PM QoS constraint for idle clamp
drm/msm/gpu: Add default devfreq thresholds

drivers/gpu/drm/msm/Kconfig | 1 +
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
drivers/gpu/drm/msm/msm_debugfs.c | 12 +++
drivers/gpu/drm/msm/msm_drv.h | 9 ++
drivers/gpu/drm/msm/msm_gpu.h | 15 ++-
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 148 ++++++++++++--------------
6 files changed, 100 insertions(+), 87 deletions(-)

--
2.38.1

2023-01-10 23:58:39

by Rob Clark

Subject: [PATCH v2 3/3] drm/msm/gpu: Add default devfreq thresholds

From: Rob Clark <[email protected]>

Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
index e578d74d402f..1f31e72ca0cf 100644
--- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
+++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
@@ -145,6 +145,15 @@ void msm_devfreq_init(struct msm_gpu *gpu)
if (!gpu->funcs->gpu_busy)
return;

+ /*
+ * Setup default values for simple_ondemand governor tuning. We
+ * want to throttle up at 50% load for the double-buffer case,
+ * where due to stalling waiting for vblank we could get stuck
+ * at (for ex) 30fps at 50% utilization.
+ */
+ priv->gpu_devfreq_config.upthreshold = 50;
+ priv->gpu_devfreq_config.downdifferential = 10;
+
mutex_init(&df->lock);

dev_pm_qos_add_request(&gpu->pdev->dev, &df->boost_freq,
--
2.38.1

2023-01-13 21:50:46

by Chia-I Wu

Subject: Re: [PATCH v2 0/3] drm/msm/gpu: Devfreq fixes+tuning

Series is

Reviewed-by: Chia-I Wu <[email protected]>


On Tue, Jan 10, 2023 at 3:14 PM Rob Clark <[email protected]> wrote:
>
> From: Rob Clark <[email protected]>
>
> Rob Clark (3):
> drm/msm/gpu: Add devfreq tuning debugfs
> drm/msm/gpu: Bypass PM QoS constraint for idle clamp
> drm/msm/gpu: Add default devfreq thresholds
>
> drivers/gpu/drm/msm/Kconfig | 1 +
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
> drivers/gpu/drm/msm/msm_debugfs.c | 12 +++
> drivers/gpu/drm/msm/msm_drv.h | 9 ++
> drivers/gpu/drm/msm/msm_gpu.h | 15 ++-
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 148 ++++++++++++--------------
> 6 files changed, 100 insertions(+), 87 deletions(-)
>
> --
> 2.38.1
>