2022-11-15 16:44:22

by Rob Clark

Subject: [PATCH] drm/msm: Enable clamp_to_idle for 7c3

From: Rob Clark <[email protected]>

This was overlooked.

Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index ebe9599a8316..e495d8e192db 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -2029,13 +2029,6 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), info->rev)))
adreno_gpu->base.hw_apriv = true;

- /*
- * For now only clamp to idle freq for devices where this is known not
- * to cause power supply issues:
- */
- if (info && (info->revn == 618))
- gpu->clamp_to_idle = true;
-
a6xx_llc_slices_init(pdev, a6xx_gpu);

ret = a6xx_set_supported_hw(&pdev->dev, config->rev);
@@ -2050,6 +2043,13 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
return ERR_PTR(ret);
}

+ /*
+ * For now only clamp to idle freq for devices where this is known not
+ * to cause power supply issues:
+ */
+ if (adreno_is_a618(adreno_gpu) || adreno_is_7c3(adreno_gpu))
+ gpu->clamp_to_idle = true;
+
/* Check if there is a GMU phandle and set it up */
node = of_parse_phandle(pdev->dev.of_node, "qcom,gmu", 0);

--
2.38.1

2022-11-15 16:45:14

by Doug Anderson

Subject: Re: [PATCH] drm/msm: Enable clamp_to_idle for 7c3

Hi,

On Tue, Nov 15, 2022 at 7:55 AM Rob Clark <[email protected]> wrote:
>
> From: Rob Clark <[email protected]>
>
> This was overlooked.
>
> Signed-off-by: Rob Clark <[email protected]>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Douglas Anderson <[email protected]>

2022-11-15 19:07:09

by Chia-I Wu

Subject: Re: [PATCH] drm/msm: Enable clamp_to_idle for 7c3

On Tue, Nov 15, 2022 at 8:01 AM Doug Anderson <[email protected]> wrote:
>
> Hi,
>
> On Tue, Nov 15, 2022 at 7:55 AM Rob Clark <[email protected]> wrote:
> >
> > From: Rob Clark <[email protected]>
> >
> > This was overlooked.
> >
> > Signed-off-by: Rob Clark <[email protected]>
> > ---
> > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Reviewed-by: Douglas Anderson <[email protected]>
Reviewed-by: Chia-I Wu <[email protected]>