2020-09-26 02:26:05

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH v5 15/17] device-dax: add an 'align' attribute

On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams <[email protected]> wrote:

> Introduce a device align attribute. While doing so, rename the region
> align attribute to be more explicitly named as so, but keep it named as
> @align to retain the API for tools like daxctl.
>
> Changes on align may not always be valid, when say certain mappings were
> created with 2M and then we switch to 1G. So, we validate all ranges
> against the new value being attempted, post resizing.
>
> Link: https://lkml.kernel.org/r/159643105944.4062302.3131761052969132784.stgit@dwillia2-desk3.amr.corp.intel.com
> Link: https://lore.kernel.org/r/[email protected]
> Signed-off-by: Joao Martins <[email protected]>
> Signed-off-by: Dan Williams <[email protected]>
>

The signoff chain implies that this was From:Joao. Please clarify?


2020-09-26 03:34:06

by Dan Williams

[permalink] [raw]
Subject: Re: [PATCH v5 15/17] device-dax: add an 'align' attribute

On Fri, Sep 25, 2020 at 7:22 PM Andrew Morton <[email protected]> wrote:
>
> On Fri, 25 Sep 2020 12:13:04 -0700 Dan Williams <[email protected]> wrote:
>
> > Introduce a device align attribute. While doing so, rename the region
> > align attribute to be more explicitly named as so, but keep it named as
> > @align to retain the API for tools like daxctl.
> >
> > Changes on align may not always be valid, when say certain mappings were
> > created with 2M and then we switch to 1G. So, we validate all ranges
> > against the new value being attempted, post resizing.
> >
> > Link: https://lkml.kernel.org/r/159643105944.4062302.3131761052969132784.stgit@dwillia2-desk3.amr.corp.intel.com
> > Link: https://lore.kernel.org/r/[email protected]
> > Signed-off-by: Joao Martins <[email protected]>
> > Signed-off-by: Dan Williams <[email protected]>
> >
>
> The signoff chain implies that this was From:Joao. Please clarify?

Yes, sorry, my script to squash the fix rewrote the author and I
failed to catch it. This indeed should be:

From: Joao Martins <[email protected]>

I double-checked, and it looks like this was the only one in the
series with that problem.