2021-09-06 04:36:24

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the cxl tree

---

Hi all,

After merging the cxl tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/nvdimm/label.c:750:32: error: 'uuid_to_nvdimm_cclass' defined but not used [-Werror=unused-function]
750 | static enum nvdimm_claim_class uuid_to_nvdimm_cclass(uuid_t *uuid)
| ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

d68bc4b2338b ("libnvdimm/labels: Add address-abstraction uuid definitions")

Exposed by commit

3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")

I have applied the following patch for today.

From: Stephen Rothwell <[email protected]>
Date: Mon, 6 Sep 2021 14:14:52 +1000
Subject: [PATCH] cxl: mark unused function as such

Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/nvdimm/label.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index 7abeb1233404..175db14c7694 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
@@ -747,6 +747,7 @@ static enum nvdimm_claim_class guid_to_nvdimm_cclass(guid_t *guid)
}

/* CXL labels store UUIDs instead of GUIDs for the same data */
+__maybe_unused
static enum nvdimm_claim_class uuid_to_nvdimm_cclass(uuid_t *uuid)
{
if (uuid_equal(uuid, &nvdimm_btt_uuid))
--
2.32.0

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2021-09-07 18:50:42

by Dan Williams

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the cxl tree

---

On Sun, Sep 5, 2021 at 9:20 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the cxl tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/nvdimm/label.c:750:32: error: 'uuid_to_nvdimm_cclass' defined but not used [-Werror=unused-function]
> 750 | static enum nvdimm_claim_class uuid_to_nvdimm_cclass(uuid_t *uuid)
> | ^~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> d68bc4b2338b ("libnvdimm/labels: Add address-abstraction uuid definitions")
>
> Exposed by commit
>
> 3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")
>
> I have applied the following patch for today.
>
> From: Stephen Rothwell <[email protected]>
> Date: Mon, 6 Sep 2021 14:14:52 +1000
> Subject: [PATCH] cxl: mark unused function as such
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/nvdimm/label.c | 1 +
> 1 file changed, 1 insertion(+)
>

Thanks for that Stephen. I'll just back this patch out and retry for
v5.16, it's not super critical.