2014-01-07 13:38:41

by Wei Yongjun

Subject: [PATCH -next] mtd: nuc900_nand: remove redundant return value check of platform_get_resource()

From: Wei Yongjun <[email protected]>

Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource().

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/mtd/nand/nuc900_nand.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
index 661fd14..9ee09a8 100644
--- a/drivers/mtd/nand/nuc900_nand.c
+++ b/drivers/mtd/nand/nuc900_nand.c
@@ -268,9 +268,6 @@ static int nuc900_nand_probe(struct platform_device *pdev)
chip->ecc.mode = NAND_ECC_SOFT;

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENXIO;
-
nuc900_nand->reg = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(nuc900_nand->reg))
return PTR_ERR(nuc900_nand->reg);

2014-01-07 23:59:07

by Jingoo Han

Subject: Re: [PATCH -next] mtd: nuc900_nand: remove redundant return value check of platform_get_resource()

On Tuesday, January 07, 2014 10:39 PM, Wei Yongjun wrote:
>
> From: Wei Yongjun <[email protected]>
>
> Remove unneeded error handling on the result of a call
> to platform_get_resource() when the value is passed to
> devm_ioremap_resource().
>
> Signed-off-by: Wei Yongjun <[email protected]>

Reviewed-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> ---
> drivers/mtd/nand/nuc900_nand.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/nuc900_nand.c b/drivers/mtd/nand/nuc900_nand.c
> index 661fd14..9ee09a8 100644
> --- a/drivers/mtd/nand/nuc900_nand.c
> +++ b/drivers/mtd/nand/nuc900_nand.c
> @@ -268,9 +268,6 @@ static int nuc900_nand_probe(struct platform_device *pdev)
> chip->ecc.mode = NAND_ECC_SOFT;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENXIO;
> -
> nuc900_nand->reg = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(nuc900_nand->reg))
> return PTR_ERR(nuc900_nand->reg);

2014-01-20 19:39:32

by Brian Norris

Subject: Re: [PATCH -next] mtd: nuc900_nand: remove redundant return value check of platform_get_resource()

On Wed, Jan 08, 2014 at 08:58:49AM +0900, Jingoo Han wrote:
> On Tuesday, January 07, 2014 10:39 PM, Wei Yongjun wrote:
> >
> > From: Wei Yongjun <[email protected]>
> >
> > Remove unneeded error handling on the result of a call
> > to platform_get_resource() when the value is passed to
> > devm_ioremap_resource().
> >
> > Signed-off-by: Wei Yongjun <[email protected]>
>
> Reviewed-by: Jingoo Han <[email protected]>

Pushed to l2-mtd.git. Thanks!

Brian