2013-07-29 04:27:57

by Wei Yongjun

Subject: [PATCH -next] x86: ce4100: remove duplicated include from ce4100.c

From: Wei Yongjun <[email protected]>

Remove duplicated include.

Signed-off-by: Wei Yongjun <[email protected]>
---
arch/x86/platform/ce4100/ce4100.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
index 8244f5e..d62e74d 100644
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -15,7 +15,6 @@
#include <linux/reboot.h>
#include <linux/serial_reg.h>
#include <linux/serial_8250.h>
-#include <linux/reboot.h>

#include <asm/ce4100.h>
#include <asm/prom.h>

2013-07-30 18:56:17

by Ingo Molnar

Subject: Re: [PATCH -next] x86: ce4100: remove duplicated include from ce4100.c

* Wei Yongjun <[email protected]> wrote:

> From: Wei Yongjun <[email protected]>
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> arch/x86/platform/ce4100/ce4100.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
> index 8244f5e..d62e74d 100644
> --- a/arch/x86/platform/ce4100/ce4100.c
> +++ b/arch/x86/platform/ce4100/ce4100.c
> @@ -15,7 +15,6 @@
> #include <linux/reboot.h>
> #include <linux/serial_reg.h>
> #include <linux/serial_8250.h>
> -#include <linux/reboot.h>
>
> #include <asm/ce4100.h>
> #include <asm/prom.h>

Hm, while at it, this file could need more cleanups:

- nonstandard comments
- various checkpatch complaints that seem legit
- col80 limits were 'solved' using ugly linebreaks

Thanks,

Ingo