2014-01-07 13:12:36

by Wei Yongjun

Subject: [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe()

From: Wei Yongjun <[email protected]>

Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
return a NULL result, so remove the useless !isp->phy check.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/power/isp1704_charger.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
index 80edb7d..0b4cf9d 100644
--- a/drivers/power/isp1704_charger.c
+++ b/drivers/power/isp1704_charger.c
@@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
ret = PTR_ERR(isp->phy);
goto fail0;
}
- if (!isp->phy)
- goto fail0;

isp->dev = &pdev->dev;
platform_set_drvdata(pdev, isp);

2014-01-25 11:22:33

by Dmitry Baryshkov

Subject: Re: [PATCH -next] isp1704_charger: remove useless check in isp1704_charger_probe()

On Tue, Jan 07, 2014 at 09:12:29PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> Neither devm_usb_get_phy_by_phandle() nor devm_usb_get_phy() can
> return a NULL result, so remove the useless !isp->phy check.

Thank you, applying.

> Signed-off-by: Wei Yongjun <[email protected]>
> ---
> drivers/power/isp1704_charger.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
> index 80edb7d..0b4cf9d 100644
> --- a/drivers/power/isp1704_charger.c
> +++ b/drivers/power/isp1704_charger.c
> @@ -444,8 +444,6 @@ static int isp1704_charger_probe(struct platform_device *pdev)
> ret = PTR_ERR(isp->phy);
> goto fail0;
> }
> - if (!isp->phy)
> - goto fail0;
>
> isp->dev = &pdev->dev;
> platform_set_drvdata(pdev, isp);