2019-06-25 13:11:32

by Ivan Khoronzhuk

Subject: [[PATCH net-next]] net: core: xdp: make __mem_id_disconnect to be static

Add missed static for local __mem_id_disconnect().

Signed-off-by: Ivan Khoronzhuk <[email protected]>
---
net/core/xdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/xdp.c b/net/core/xdp.c
index b29d7b513a18..829377cc83db 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -85,7 +85,7 @@ static void __xdp_mem_allocator_rcu_free(struct rcu_head *rcu)
kfree(xa);
}

-bool __mem_id_disconnect(int id, bool force)
+static bool __mem_id_disconnect(int id, bool force)
{
struct xdp_mem_allocator *xa;
bool safe_to_remove = true;
--
2.17.1

2019-06-25 22:22:41

by Song Liu

Subject: Re: [[PATCH net-next]] net: core: xdp: make __mem_id_disconnect to be static

On Tue, Jun 25, 2019 at 6:11 AM Ivan Khoronzhuk
<[email protected]> wrote:
>
> Add missed static for local __mem_id_disconnect().
>
> Signed-off-by: Ivan Khoronzhuk <[email protected]>

https://patchwork.ozlabs.org/patch/1121730/

I guess you are a little late. :)

Please ack the other patch.

Song

> ---
> net/core/xdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/xdp.c b/net/core/xdp.c
> index b29d7b513a18..829377cc83db 100644
> --- a/net/core/xdp.c
> +++ b/net/core/xdp.c
> @@ -85,7 +85,7 @@ static void __xdp_mem_allocator_rcu_free(struct rcu_head *rcu)
> kfree(xa);
> }
>
> -bool __mem_id_disconnect(int id, bool force)
> +static bool __mem_id_disconnect(int id, bool force)
> {
> struct xdp_mem_allocator *xa;
> bool safe_to_remove = true;
> --
> 2.17.1
>