2021-12-26 02:24:16

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] md: fix spelling of "its"

Use the possessive "its" instead of the contraction "it's"
in printed messages.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Song Liu <[email protected]>
Cc: [email protected]
---
drivers/md/md-cluster.c | 2 +-
drivers/md/md.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-next-20211224.orig/drivers/md/md.c
+++ linux-next-20211224/drivers/md/md.c
@@ -8402,7 +8402,7 @@ int md_setup_cluster(struct mddev *mddev
spin_lock(&pers_lock);
/* ensure module won't be unloaded */
if (!md_cluster_ops || !try_module_get(md_cluster_mod)) {
- pr_warn("can't find md-cluster module or get it's reference.\n");
+ pr_warn("can't find md-cluster module or get its reference.\n");
spin_unlock(&pers_lock);
return -ENOENT;
}
--- linux-next-20211224.orig/drivers/md/md-cluster.c
+++ linux-next-20211224/drivers/md/md-cluster.c
@@ -574,7 +574,7 @@ static int process_recvd_msg(struct mdde
int ret = 0;

if (WARN(mddev->cluster_info->slot_number - 1 == le32_to_cpu(msg->slot),
- "node %d received it's own msg\n", le32_to_cpu(msg->slot)))
+ "node %d received its own msg\n", le32_to_cpu(msg->slot)))
return -1;
switch (le32_to_cpu(msg->type)) {
case METADATA_UPDATED:


2022-01-02 00:06:47

by Song Liu

[permalink] [raw]
Subject: Re: [PATCH] md: fix spelling of "its"

On Sat, Dec 25, 2021 at 6:24 PM Randy Dunlap <[email protected]> wrote:
>
> Use the possessive "its" instead of the contraction "it's"
> in printed messages.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Song Liu <[email protected]>
> Cc: [email protected]

Applied to md-next.

Thanks!

> ---
> drivers/md/md-cluster.c | 2 +-
> drivers/md/md.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20211224.orig/drivers/md/md.c
> +++ linux-next-20211224/drivers/md/md.c
> @@ -8402,7 +8402,7 @@ int md_setup_cluster(struct mddev *mddev
> spin_lock(&pers_lock);
> /* ensure module won't be unloaded */
> if (!md_cluster_ops || !try_module_get(md_cluster_mod)) {
> - pr_warn("can't find md-cluster module or get it's reference.\n");
> + pr_warn("can't find md-cluster module or get its reference.\n");
> spin_unlock(&pers_lock);
> return -ENOENT;
> }
> --- linux-next-20211224.orig/drivers/md/md-cluster.c
> +++ linux-next-20211224/drivers/md/md-cluster.c
> @@ -574,7 +574,7 @@ static int process_recvd_msg(struct mdde
> int ret = 0;
>
> if (WARN(mddev->cluster_info->slot_number - 1 == le32_to_cpu(msg->slot),
> - "node %d received it's own msg\n", le32_to_cpu(msg->slot)))
> + "node %d received its own msg\n", le32_to_cpu(msg->slot)))
> return -1;
> switch (le32_to_cpu(msg->type)) {
> case METADATA_UPDATED:

2022-01-02 01:50:25

by Wols Lists

[permalink] [raw]
Subject: Re: [PATCH] md: fix spelling of "its"

On 02/01/2022 00:06, Song Liu wrote:
> On Sat, Dec 25, 2021 at 6:24 PM Randy Dunlap<[email protected]> wrote:
>> Use the possessive "its" instead of the contraction "it's"
>> in printed messages.
>>
>> Signed-off-by: Randy Dunlap<[email protected]>
>> Cc: Song Liu<[email protected]>
>> Cc:[email protected]
> Applied to md-next.
>
> Thanks!
>
For the benefit of non-native English speakers, the possessive ending is
NOT " 's ". In practice it usually does tend to be, though.

The regular historic possessive ending is -es. An apostrophe replaces
elided letters - and for whatever reason in modern English that "e" is
almost always elided, hence " 's " :-)

(Which is why the possessive plural ending is usually a trailing
apostrophe. The possessive of (plural) cats was "catses", now
abbreviated to " cats' ".)

However, with the word "it", the irregular possessive form is "its", and
when you see " it's ", it's actually a contraction of " it is ", the "i"
has been elided and replaced by the apostrophe.

I remember seeing a big sign outside a shop where they proudly announced
they had been granted a "Certificate of Excellence". And in about 20
words, they had the word "its" six times. Spelt wrong EVERY SINGLE TIME :-)

Cheers,
Wol