2022-08-26 03:54:40

by James Hilliard

Subject: [PATCH] selftests/bpf: declare subprog_noise as static in tailcall_bpf2bpf4

Due to bpf_map_lookup_elem being declared static we need to also
declare subprog_noise as static.

Fixes the following error:
progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror]
26 | bpf_map_lookup_elem(&nop_table, &key);
| ^~~~~~~~~~~~~~~~~~~

Signed-off-by: James Hilliard <[email protected]>
---
tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
index b67e8022d500..a017d6b2f1dd 100644
--- a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
+++ b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
@@ -19,7 +19,7 @@ struct {
int count = 0;
int noise = 0;

-__always_inline int subprog_noise(void)
+static __always_inline int subprog_noise(void)
{
__u32 key = 0;

--
2.34.1

2022-08-26 05:10:50

by Song Liu

Subject: Re: [PATCH] selftests/bpf: declare subprog_noise as static in tailcall_bpf2bpf4

On Thu, Aug 25, 2022 at 8:52 PM James Hilliard
<[email protected]> wrote:
>
> Due to bpf_map_lookup_elem being declared static we need to also
> declare subprog_noise as static.
>
> Fixes the following error:
> progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror]
> 26 | bpf_map_lookup_elem(&nop_table, &key);
> | ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: James Hilliard <[email protected]>

Acked-by: Song Liu <[email protected]>

> ---
> tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
> index b67e8022d500..a017d6b2f1dd 100644
> --- a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
> +++ b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
> @@ -19,7 +19,7 @@ struct {
> int count = 0;
> int noise = 0;
>
> -__always_inline int subprog_noise(void)
> +static __always_inline int subprog_noise(void)
> {
> __u32 key = 0;
>
> --
> 2.34.1
>

2022-08-27 05:18:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] selftests/bpf: declare subprog_noise as static in tailcall_bpf2bpf4

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <[email protected]>:

On Thu, 25 Aug 2022 21:51:39 -0600 you wrote:
> Due to bpf_map_lookup_elem being declared static we need to also
> declare subprog_noise as static.
>
> Fixes the following error:
> progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror]
> 26 | bpf_map_lookup_elem(&nop_table, &key);
> | ^~~~~~~~~~~~~~~~~~~
>
> [...]

Here is the summary with links:
- selftests/bpf: declare subprog_noise as static in tailcall_bpf2bpf4
https://git.kernel.org/bpf/bpf-next/c/b05d64efbb21

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html