2019-01-29 04:07:37

by Valdis Klētnieks

Subject: [PATCH] kernel/bpf/core.c - fix bitrotted kerneldoc.

Over the years, the function signature has changed, the kerneldoc block hasn't.

Signed-off-by: Valdis Kletnieks <[email protected]>

diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
index 2a81b8af3748..2728b6247091 100644
--- a/kernel/bpf/core.c
+++ b/kernel/bpf/core.c
@@ -1216,8 +1216,9 @@ bool bpf_opcode_in_insntable(u8 code)
#ifndef CONFIG_BPF_JIT_ALWAYS_ON
/**
* __bpf_prog_run - run eBPF program on a given context
- * @ctx: is the data we are operating on
+ * @regs: is the array of MAX_BPF_EXT_REG eBPF pseudo-registers
* @insn: is the array of eBPF instructions
+ * @stack: is the eBPF storage stack
*
* Decode and execute eBPF instructions.
*/

2019-01-29 22:13:42

by Song Liu

Subject: Re: [PATCH] kernel/bpf/core.c - fix bitrotted kerneldoc.

On Mon, Jan 28, 2019 at 8:06 PM <[email protected]> wrote:
>
> Over the years, the function signature has changed, the kerneldoc block hasn't.
>
> Signed-off-by: Valdis Kletnieks <[email protected]>
Acked-by: Song Liu <[email protected]>

>
> diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
> index 2a81b8af3748..2728b6247091 100644
> --- a/kernel/bpf/core.c
> +++ b/kernel/bpf/core.c
> @@ -1216,8 +1216,9 @@ bool bpf_opcode_in_insntable(u8 code)
> #ifndef CONFIG_BPF_JIT_ALWAYS_ON
> /**
> * __bpf_prog_run - run eBPF program on a given context
> - * @ctx: is the data we are operating on
> + * @regs: is the array of MAX_BPF_EXT_REG eBPF pseudo-registers
> * @insn: is the array of eBPF instructions
> + * @stack: is the eBPF storage stack
> *
> * Decode and execute eBPF instructions.
> */
>