2018-06-22 18:56:41

by Jeffrin Jose T

Subject: [PATCH] selftests: bpf: notification about privilege required to run test_lirc_mode2.sh testing script

The test_lirc_mode2.sh script require root privilege for the successful
execution of the test.

This patch is to notify the user about the privilege the script
demands for the successful execution of the test.

Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>
---
tools/testing/selftests/bpf/test_lirc_mode2.sh | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
index ce2e15e4f976..51184f8f9e64 100755
--- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
+++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
@@ -1,6 +1,15 @@
#!/bin/bash
# SPDX-License-Identifier: GPL-2.0

+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+msg="skip all tests:"
+if [ $UID != 0 ]; then
+ echo $msg please run this as root >&2
+ exit $ksft_skip
+fi
+
GREEN='\033[0;92m'
RED='\033[0;31m'
NC='\033[0m' # No Color
--
2.17.0

2018-06-25 05:09:49

by Song Liu

Subject: Re: [PATCH] selftests: bpf: notification about privilege required to run test_lirc_mode2.sh testing script

On Fri, Jun 22, 2018 at 11:54 AM, Jeffrin Jose T <[email protected]> wrote:
> The test_lirc_mode2.sh script require root privilege for the successful
> execution of the test.
>
> This patch is to notify the user about the privilege the script
> demands for the successful execution of the test.
>
> Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>

Acked-by: Song Liu <[email protected]>

> ---
> tools/testing/selftests/bpf/test_lirc_mode2.sh | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_lirc_mode2.sh b/tools/testing/selftests/bpf/test_lirc_mode2.sh
> index ce2e15e4f976..51184f8f9e64 100755
> --- a/tools/testing/selftests/bpf/test_lirc_mode2.sh
> +++ b/tools/testing/selftests/bpf/test_lirc_mode2.sh
> @@ -1,6 +1,15 @@
> #!/bin/bash
> # SPDX-License-Identifier: GPL-2.0
>
> +# Kselftest framework requirement - SKIP code is 4.
> +ksft_skip=4
> +
> +msg="skip all tests:"
> +if [ $UID != 0 ]; then
> + echo $msg please run this as root >&2
> + exit $ksft_skip
> +fi
> +
> GREEN='\033[0;92m'
> RED='\033[0;31m'
> NC='\033[0m' # No Color
> --
> 2.17.0
>

2018-06-26 10:24:09

by Daniel Borkmann

Subject: Re: [PATCH] selftests: bpf: notification about privilege required to run test_lirc_mode2.sh testing script

On 06/22/2018 08:54 PM, Jeffrin Jose T wrote:
> The test_lirc_mode2.sh script require root privilege for the successful
> execution of the test.
>
> This patch is to notify the user about the privilege the script
> demands for the successful execution of the test.
>
> Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>

Applied to bpf, thanks Jeffrin!