2019-07-01 12:24:59

by Markus Elfring

Subject: [PATCH] md-multipath: Replace a seq_printf() call by seq_putc() in multipath_status()

From: Markus Elfring <[email protected]>
Date: Mon, 1 Jul 2019 13:07:55 +0200

A single character (depending on a condition check) should be put
into a sequence. Thus use the corresponding function “seq_putc”.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/md/md-multipath.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/md/md-multipath.c b/drivers/md/md-multipath.c
index 6780938d2991..3bf6f97ea264 100644
--- a/drivers/md/md-multipath.c
+++ b/drivers/md/md-multipath.c
@@ -146,7 +146,8 @@ static void multipath_status(struct seq_file *seq, struct mddev *mddev)
rcu_read_lock();
for (i = 0; i < conf->raid_disks; i++) {
struct md_rdev *rdev = rcu_dereference(conf->multipaths[i].rdev);
- seq_printf (seq, "%s", rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_");
+ seq_putc(seq,
+ rdev && test_bit(In_sync, &rdev->flags) ? 'U' : '_');
}
rcu_read_unlock();
seq_putc(seq, ']');
--
2.22.0

2019-07-03 12:19:34

by Song Liu

Subject: Re: [PATCH] md-multipath: Replace a seq_printf() call by seq_putc() in multipath_status()

On Mon, Jul 1, 2019 at 5:25 AM Markus Elfring <[email protected]> wrote:
>
> From: Markus Elfring <[email protected]>
> Date: Mon, 1 Jul 2019 13:07:55 +0200
>
> A single character (depending on a condition check) should be put
> into a sequence. Thus use the corresponding function “seq_putc”.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Can you explain why this is necessary?

Thanks,
Song

2019-07-03 16:29:39

by Markus Elfring

Subject: Re: md-multipath: Replace a seq_printf() call by seq_putc() in multipath_status()

>> A single character (depending on a condition check) should be put
>> into a sequence. Thus use the corresponding function “seq_putc”.
…
> Can you explain why this is necessary?

I suggest another bit of software fine-tuning.

* Pass only a relevant character instead of a string.

* Omit the format string for a function parameter.

Regards,
Markus