2023-09-26 22:16:28

by Simon Glass

[permalink] [raw]
Subject: [PATCH v7 1/2] schemas: memory: Add ECC properties

Some memories provide ECC detection and/or correction. For software which
wants to check memory, it is helpful to see which regions provide this
feature.

Add this as a property of the /memory nodes, since it presumably follows
the hardware-level memory system.

Signed-off-by: Simon Glass <[email protected]>
---

Changes in v7:
- Drop unnecessary |
- Add a blank line between properties

Changes in v6:
- Use a number of bits instead of a string property
- Fix inidcates typo

Changes in v5:
- Redo to make this property specific to ECC
- Provide properties both for detection and correction

Changes in v3:
- Add new patch to update the /memory nodes

dtschema/schemas/memory.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/dtschema/schemas/memory.yaml b/dtschema/schemas/memory.yaml
index 1d74410..b3bf3c9 100644
--- a/dtschema/schemas/memory.yaml
+++ b/dtschema/schemas/memory.yaml
@@ -35,6 +35,19 @@ patternProperties:
For the purpose of identification, each NUMA node is associated with
a unique token known as a node id.

+ ecc-detection-bits:
+ default: 0
+ description: |
+ If present, this indicates the number of bits of memory error which
+ can be detected and reported by the Error-Correction Code (ECC) memory
+ subsystem (typically 0, 1 or 2).
+
+ ecc-correction-bits:
+ default: 0
+ description: |
+ If present, this indicates the number of bits of memory error which
+ can be corrected by the Error-Correction Code (ECC) memory subsystem
+ (typically 0, 1 or 2).

required:
- device_type
--
2.42.0.515.g380fc7ccd1-goog


2023-10-09 19:23:04

by Simon Glass

[permalink] [raw]
Subject: Re: [PATCH v7 1/2] schemas: memory: Add ECC properties

Hi Rob,

On Tue, 26 Sept 2023 at 13:42, Simon Glass <[email protected]> wrote:
>
> Some memories provide ECC detection and/or correction. For software which
> wants to check memory, it is helpful to see which regions provide this
> feature.
>
> Add this as a property of the /memory nodes, since it presumably follows
> the hardware-level memory system.
>
> Signed-off-by: Simon Glass <[email protected]>
> ---
>
> Changes in v7:
> - Drop unnecessary |
> - Add a blank line between properties
>
> Changes in v6:
> - Use a number of bits instead of a string property
> - Fix inidcates typo
>
> Changes in v5:
> - Redo to make this property specific to ECC
> - Provide properties both for detection and correction
>
> Changes in v3:
> - Add new patch to update the /memory nodes
>
> dtschema/schemas/memory.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/dtschema/schemas/memory.yaml b/dtschema/schemas/memory.yaml
> index 1d74410..b3bf3c9 100644
> --- a/dtschema/schemas/memory.yaml
> +++ b/dtschema/schemas/memory.yaml
> @@ -35,6 +35,19 @@ patternProperties:
> For the purpose of identification, each NUMA node is associated with
> a unique token known as a node id.
>
> + ecc-detection-bits:
> + default: 0
> + description: |
> + If present, this indicates the number of bits of memory error which
> + can be detected and reported by the Error-Correction Code (ECC) memory
> + subsystem (typically 0, 1 or 2).
> +
> + ecc-correction-bits:
> + default: 0
> + description: |
> + If present, this indicates the number of bits of memory error which
> + can be corrected by the Error-Correction Code (ECC) memory subsystem
> + (typically 0, 1 or 2).
>
> required:
> - device_type
> --
> 2.42.0.515.g380fc7ccd1-goog
>

What is the status of this patch, please?

Regards,
Simon

2023-10-16 19:57:43

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v7 1/2] schemas: memory: Add ECC properties

On Tue, Sep 26, 2023 at 01:42:38PM -0600, Simon Glass wrote:
> Some memories provide ECC detection and/or correction. For software which
> wants to check memory, it is helpful to see which regions provide this
> feature.
>
> Add this as a property of the /memory nodes, since it presumably follows
> the hardware-level memory system.
>
> Signed-off-by: Simon Glass <[email protected]>
> ---
>
> Changes in v7:
> - Drop unnecessary |
> - Add a blank line between properties
>
> Changes in v6:
> - Use a number of bits instead of a string property
> - Fix inidcates typo
>
> Changes in v5:
> - Redo to make this property specific to ECC
> - Provide properties both for detection and correction
>
> Changes in v3:
> - Add new patch to update the /memory nodes
>
> dtschema/schemas/memory.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)

Applied this patch.

Rob

2023-10-16 21:54:36

by Simon Glass

[permalink] [raw]
Subject: Re: [PATCH v7 1/2] schemas: memory: Add ECC properties

Hi Rob,

On Mon, 16 Oct 2023 at 13:57, Rob Herring <[email protected]> wrote:
>
> On Tue, Sep 26, 2023 at 01:42:38PM -0600, Simon Glass wrote:
> > Some memories provide ECC detection and/or correction. For software which
> > wants to check memory, it is helpful to see which regions provide this
> > feature.
> >
> > Add this as a property of the /memory nodes, since it presumably follows
> > the hardware-level memory system.
> >
> > Signed-off-by: Simon Glass <[email protected]>
> > ---
> >
> > Changes in v7:
> > - Drop unnecessary |
> > - Add a blank line between properties
> >
> > Changes in v6:
> > - Use a number of bits instead of a string property
> > - Fix inidcates typo
> >
> > Changes in v5:
> > - Redo to make this property specific to ECC
> > - Provide properties both for detection and correction
> >
> > Changes in v3:
> > - Add new patch to update the /memory nodes
> >
> > dtschema/schemas/memory.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
>
> Applied this patch.

Thank you for your help and guidance on this.

Regards,
Simon