On Fri, Nov 17, 2017 at 9:53 AM, Philippe Ombredanne
<[email protected]> wrote:
> On Fri, Nov 17, 2017 at 3:20 PM, Greg Kroah-Hartman
> <[email protected]> wrote:
>> There is no need to #define the license of the driver, just put it in
>> the MODULE_LICENSE() line directly as a text string.
>>
>> This allows tools that check that the module license matches the source
>> code license to work properly, as there is no need to unwind the
>> unneeded dereference, especially when the string is defined just a few
>> lines above the usage of it.
>>
>> Cc: Jon Mason <[email protected]>
>> Cc: Dave Jiang <[email protected]>
>> Cc: Allen Hubbe <[email protected]>
>> Cc: Gary R Hook <[email protected]>
>> Cc: Serge Semin <[email protected]>
>> Reported-by: Philippe Ombredanne <[email protected]>
>> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>
>
> Reviewed-by: Philippe Ombredanne <[email protected]>
Applied to my ntb-next branch.
Thanks,
Jon
> --
> Cordially
> Philippe Ombredanne
From 1584346772537859806@xxx Fri Nov 17 20:33:45 +0000 2017
X-GM-THRID: 1584342339242413457
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread