Subject: [PATCH 16/38] sgi-xpc: Replace deprecated CPU-hotplug functions.

The functions get_online_cpus() and put_online_cpus() have been
deprecated during the CPU hotplug rework. They map directly to
cpus_read_lock() and cpus_read_unlock().

Replace deprecated CPU-hotplug functions with the official version.
The behavior remains unchanged.

Cc: Robin Holt <[email protected]>
Cc: Steve Wahl <[email protected]>
Cc: Mike Travis <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
---
drivers/misc/sgi-xp/xpc_uv.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
index 7791bde81a368..ba9ae0e2df0fe 100644
--- a/drivers/misc/sgi-xp/xpc_uv.c
+++ b/drivers/misc/sgi-xp/xpc_uv.c
@@ -1742,7 +1742,7 @@ xpc_init_mq_node(int nid)
{
int cpu;

- get_online_cpus();
+ cpus_read_lock();

for_each_cpu(cpu, cpumask_of_node(nid)) {
xpc_activate_mq_uv =
@@ -1753,7 +1753,7 @@ xpc_init_mq_node(int nid)
break;
}
if (IS_ERR(xpc_activate_mq_uv)) {
- put_online_cpus();
+ cpus_read_unlock();
return PTR_ERR(xpc_activate_mq_uv);
}

@@ -1767,11 +1767,11 @@ xpc_init_mq_node(int nid)
}
if (IS_ERR(xpc_notify_mq_uv)) {
xpc_destroy_gru_mq_uv(xpc_activate_mq_uv);
- put_online_cpus();
+ cpus_read_unlock();
return PTR_ERR(xpc_notify_mq_uv);
}

- put_online_cpus();
+ cpus_read_unlock();
return 0;
}

--
2.32.0



2021-08-03 15:58:50

by Steve Wahl

[permalink] [raw]
Subject: Re: [PATCH 16/38] sgi-xpc: Replace deprecated CPU-hotplug functions.

Reviewed-by: Steve Wahl <[email protected]>

On Tue, Aug 03, 2021 at 04:15:59PM +0200, Sebastian Andrzej Siewior wrote:
> The functions get_online_cpus() and put_online_cpus() have been
> deprecated during the CPU hotplug rework. They map directly to
> cpus_read_lock() and cpus_read_unlock().
>
> Replace deprecated CPU-hotplug functions with the official version.
> The behavior remains unchanged.
>
> Cc: Robin Holt <[email protected]>
> Cc: Steve Wahl <[email protected]>
> Cc: Mike Travis <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
> ---
> drivers/misc/sgi-xp/xpc_uv.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
> index 7791bde81a368..ba9ae0e2df0fe 100644
> --- a/drivers/misc/sgi-xp/xpc_uv.c
> +++ b/drivers/misc/sgi-xp/xpc_uv.c
> @@ -1742,7 +1742,7 @@ xpc_init_mq_node(int nid)
> {
> int cpu;
>
> - get_online_cpus();
> + cpus_read_lock();
>
> for_each_cpu(cpu, cpumask_of_node(nid)) {
> xpc_activate_mq_uv =
> @@ -1753,7 +1753,7 @@ xpc_init_mq_node(int nid)
> break;
> }
> if (IS_ERR(xpc_activate_mq_uv)) {
> - put_online_cpus();
> + cpus_read_unlock();
> return PTR_ERR(xpc_activate_mq_uv);
> }
>
> @@ -1767,11 +1767,11 @@ xpc_init_mq_node(int nid)
> }
> if (IS_ERR(xpc_notify_mq_uv)) {
> xpc_destroy_gru_mq_uv(xpc_activate_mq_uv);
> - put_online_cpus();
> + cpus_read_unlock();
> return PTR_ERR(xpc_notify_mq_uv);
> }
>
> - put_online_cpus();
> + cpus_read_unlock();
> return 0;
> }
>
> --
> 2.32.0
>

--
Steve Wahl, Hewlett Packard Enterprise

2021-08-03 21:46:26

by Robin Holt

[permalink] [raw]
Subject: Re: [PATCH 16/38] sgi-xpc: Replace deprecated CPU-hotplug functions.

> Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Acked-by: Robin Holt <[email protected]