2017-04-02 15:20:18

by Santosh Kumar Singh

Subject: [PATCH] misc: sgi-xp: Use setup_timer Kernel API instead of

Replace init_timer function with setup_timer reported by coccinelle

Signed-off-by: Santosh Kumar Singh <[email protected]>
---
drivers/misc/sgi-xp/xpc_main.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/misc/sgi-xp/xpc_main.c b/drivers/misc/sgi-xp/xpc_main.c
index 7f32712..9545157 100644
--- a/drivers/misc/sgi-xp/xpc_main.c
+++ b/drivers/misc/sgi-xp/xpc_main.c
@@ -931,11 +931,8 @@ struct device xpc_chan_dbg_subname = {
part->act_state = XPC_P_AS_INACTIVE;
XPC_SET_REASON(part, 0, 0);

- init_timer(&part->disengage_timer);
- part->disengage_timer.function =
- xpc_timeout_partition_disengage;
- part->disengage_timer.data = (unsigned long)part;
-
+ setup_timer(&part->disengage_timer,
+ xpc_timeout_partition_disengage,
+ (unsigned long)part);
part->setup_state = XPC_P_SS_UNSET;
init_waitqueue_head(&part->teardown_wq);
atomic_set(&part->references, 0);
--
1.9.1

2017-04-06 19:10:41

by Robin Holt

Subject: Re: [PATCH] misc: sgi-xp: Use setup_timer Kernel API instead of

On Sun, Apr 2, 2017 at 10:17 AM, Santosh Kumar Singh
<[email protected]> wrote:
> Replace init_timer function with setup_timer reported by coccinelle
>
> Signed-off-by: Santosh Kumar Singh <[email protected]>
Acked-by: Robin Holt <[email protected]>