2018-04-24 14:39:45

by Luc Van Oostenryck

Subject: [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, but the implementation in this
driver returns an 'int'.

Fix this by returning 'netdev_tx_t' in this driver too.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
drivers/misc/sgi-xp/xpnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-xp/xpnet.c b/drivers/misc/sgi-xp/xpnet.c
index 0c26eaf5f..216d5c756 100644
--- a/drivers/misc/sgi-xp/xpnet.c
+++ b/drivers/misc/sgi-xp/xpnet.c
@@ -407,7 +407,7 @@ xpnet_send(struct sk_buff *skb, struct xpnet_pending_msg *queued_msg,
* destination partid. If the destination partid octets are 0xffff,
* this packet is to be broadcast to all connected partitions.
*/
-static int
+static netdev_tx_t
xpnet_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
{
struct xpnet_pending_msg *queued_msg;
--
2.17.0

2018-04-24 17:30:34

by Robin Holt

Subject: Re: [PATCH] sgi-xp: fix xpnet_dev_hard_start_xmit()'s return type

On Tue, Apr 24, 2018 at 8:15 AM, Luc Van Oostenryck
<[email protected]> wrote:
> Signed-off-by: Luc Van Oostenryck <[email protected]>
Acked-by: Robin Holt <[email protected]>