On Mon, Mar 23, 2015 at 05:51:05PM -0500, Kumar Gala wrote:
> Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board.
> This board is also referred to as the DragonBoard 410c.
>
> Signed-off-by: Kumar Gala <[email protected]>
Hi,
Patch applied but see comment below.
> ---
> arch/arm64/boot/dts/qcom/Makefile | 2 +-
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 22 +++++++++++++++++++++
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 33 +++++++++++++++++++++++++++++++
> 3 files changed, 56 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> create mode 100644 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 360ec4c..8e94af6 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -1,4 +1,4 @@
> -dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb
>
> always := $(dtb-y)
> subdir-y := $(dts-dirs)
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> new file mode 100644
> index 0000000..3c563e7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -0,0 +1,22 @@
> +/*
> + * Copyright (c) 2015, The Linux Foundation. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
Your 32-bit DTS:es lack copyright headers alltogether, and this is GPLv2 only.
Given the movement to use dual GPL/X11 on DTS contents, it might be a good idea
to kick off that process with your legal team if you haven't already. Please
follow up with copyright revisions as appropriate, on both 32 and 64-bit.
-Olof
On Fri, Apr 03, 2015 at 11:12:17AM -0700, Olof Johansson wrote:
> On Mon, Mar 23, 2015 at 05:51:05PM -0500, Kumar Gala wrote:
> > Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board.
> > This board is also referred to as the DragonBoard 410c.
> >
> > Signed-off-by: Kumar Gala <[email protected]>
>
> Hi,
>
> Patch applied but see comment below.
You both sent us the patch and a pull request with this patch in
it. Please only send patches to [email protected] that you intend for us
to apply.
-Olof
On Fri, Apr 03, 2015 at 11:14:01AM -0700, Olof Johansson wrote:
> On Fri, Apr 03, 2015 at 11:12:17AM -0700, Olof Johansson wrote:
> > On Mon, Mar 23, 2015 at 05:51:05PM -0500, Kumar Gala wrote:
> > > Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board.
> > > This board is also referred to as the DragonBoard 410c.
> > >
> > > Signed-off-by: Kumar Gala <[email protected]>
> >
> > Hi,
> >
> > Patch applied but see comment below.
>
> You both sent us the patch and a pull request with this patch in
> it. Please only send patches to [email protected] that you intend for us
> to apply.
Uh, need more coffee, please ignore. I got confused since your patch didn't
apply cleanly due to the dts/qcom directory creation.
-Olof
On Apr 3, 2015, at 1:18 PM, Olof Johansson <[email protected]> wrote:
> On Fri, Apr 03, 2015 at 11:14:01AM -0700, Olof Johansson wrote:
>> On Fri, Apr 03, 2015 at 11:12:17AM -0700, Olof Johansson wrote:
>>> On Mon, Mar 23, 2015 at 05:51:05PM -0500, Kumar Gala wrote:
>>>> Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board.
>>>> This board is also referred to as the DragonBoard 410c.
>>>>
>>>> Signed-off-by: Kumar Gala <[email protected]>
>>>
>>> Hi,
>>>
>>> Patch applied but see comment below.
>>
>> You both sent us the patch and a pull request with this patch in
>> it. Please only send patches to [email protected] that you intend for us
>> to apply.
>
> Uh, need more coffee, please ignore. I got confused since your patch didn't
> apply cleanly due to the dts/qcom directory creation.
>
>
> -Olof
Ok, but this should be part of the 'qcom-dt-for-4.1? so hopefully you will end up pulling all of that in as well
- k
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Fri, Apr 3, 2015 at 12:13 PM, Kumar Gala <[email protected]> wrote:
>
> On Apr 3, 2015, at 1:18 PM, Olof Johansson <[email protected]> wrote:
>
>> On Fri, Apr 03, 2015 at 11:14:01AM -0700, Olof Johansson wrote:
>>> On Fri, Apr 03, 2015 at 11:12:17AM -0700, Olof Johansson wrote:
>>>> On Mon, Mar 23, 2015 at 05:51:05PM -0500, Kumar Gala wrote:
>>>>> Add initial device tree support for Qualcomm APQ8016 SBC Evaluation board.
>>>>> This board is also referred to as the DragonBoard 410c.
>>>>>
>>>>> Signed-off-by: Kumar Gala <[email protected]>
>>>>
>>>> Hi,
>>>>
>>>> Patch applied but see comment below.
>>>
>>> You both sent us the patch and a pull request with this patch in
>>> it. Please only send patches to [email protected] that you intend for us
>>> to apply.
>>
>> Uh, need more coffee, please ignore. I got confused since your patch didn't
>> apply cleanly due to the dts/qcom directory creation.
>>
>>
>> -Olof
>
> Ok, but this should be part of the 'qcom-dt-for-4.1’ so hopefully you will end up pulling all of that in as well
If you pick up a patch that you have sent us, please reply to that
email with a redaction so we don't waste time dealing with it.
Especially if some time has passed.
I'll get to your dt branch this afternoon.
-Olof