2006-05-08 20:56:24

by Kylene Jo Hall

[permalink] [raw]
Subject: [PATCH] tpm: update module dependencies

The TIS driver is dependent upon information from the ACPI table for
device discovery thus it compiles but does no actual work with out this
dependency.

Signed-off-by: Kylene Hall <[email protected]>
---
drivers/char/tpm/Kconfig | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.17-rc3/drivers/char/tpm/Kconfig 2006-04-26 21:19:25.000000000 -0500
+++ linux-2.6.17-rc3-tpm/drivers/char/tpm/Kconfig 2006-05-08 16:11:03.707961750 -0500
@@ -22,7 +22,7 @@ config TCG_TPM

config TCG_TIS
tristate "TPM Interface Specification 1.2 Interface"
- depends on TCG_TPM
+ depends on TCG_TPM && PNPACPI
---help---
If you have a TPM security chip that is compliant with the
TCG TIS 1.2 TPM specification say Yes and it will be accessible



2006-05-08 22:01:16

by Brown, Len

[permalink] [raw]
Subject: RE: [PATCH] tpm: update module dependencies


>The TIS driver is dependent upon information from the ACPI table for
>device discovery thus it compiles but does no actual work with out this
>dependency.
>
>Signed-off-by: Kylene Hall <[email protected]>
>---
> drivers/char/tpm/Kconfig | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>--- linux-2.6.17-rc3/drivers/char/tpm/Kconfig 2006-04-26
>21:19:25.000000000 -0500
>+++ linux-2.6.17-rc3-tpm/drivers/char/tpm/Kconfig
>2006-05-08 16:11:03.707961750 -0500
>@@ -22,7 +22,7 @@ config TCG_TPM
>
> config TCG_TIS
> tristate "TPM Interface Specification 1.2 Interface"
>- depends on TCG_TPM
>+ depends on TCG_TPM && PNPACPI

I think you want simply "ACPI" rather than "PNPACPI" here, yes?

-Len

2006-05-08 22:14:32

by Kylene Jo Hall

[permalink] [raw]
Subject: RE: [PATCH] tpm: update module dependencies

No I think I really want PNPACPI because I have a pnp_driver which
probes based on a CID value. PNPACPI is dependent on ACPI. Am I
misunderstanding something. It works with PNPACPI on but turning off
only PNPACPI causes it to not work.

Thanks,
Kylie

On Mon, 2006-05-08 at 17:59 -0400, Brown, Len wrote:
> >The TIS driver is dependent upon information from the ACPI table for
> >device discovery thus it compiles but does no actual work with out this
> >dependency.
> >
> >Signed-off-by: Kylene Hall <[email protected]>
> >---
> > drivers/char/tpm/Kconfig | 2 +-
> > 1 files changed, 1 insertion(+), 1 deletion(-)
> >
> >--- linux-2.6.17-rc3/drivers/char/tpm/Kconfig 2006-04-26
> >21:19:25.000000000 -0500
> >+++ linux-2.6.17-rc3-tpm/drivers/char/tpm/Kconfig
> >2006-05-08 16:11:03.707961750 -0500
> >@@ -22,7 +22,7 @@ config TCG_TPM
> >
> > config TCG_TIS
> > tristate "TPM Interface Specification 1.2 Interface"
> >- depends on TCG_TPM
> >+ depends on TCG_TPM && PNPACPI
>
> I think you want simply "ACPI" rather than "PNPACPI" here, yes?
>
> -Len