2021-12-08 17:52:52

by José Expósito

Subject: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

Addresses-Coverity-ID: 1493352 ("Resource leak")
Signed-off-by: José Expósito <[email protected]>
---
drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c b/drivers/infiniband/hw/qib/qib_user_sdma.c
index ac11943a5ddb..bf2f30d67949 100644
--- a/drivers/infiniband/hw/qib/qib_user_sdma.c
+++ b/drivers/infiniband/hw/qib/qib_user_sdma.c
@@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct qib_devdata *dd,
&addrlimit) ||
addrlimit > type_max(typeof(pkt->addrlimit))) {
ret = -EINVAL;
- goto free_pbc;
+ goto free_pkt;
}
pkt->addrlimit = addrlimit;

--
2.25.1

2021-12-08 18:07:51

by Marciniszyn, Mike

Subject: RE: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

> Subject: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts
>
> Addresses-Coverity-ID: 1493352 ("Resource leak")
> Signed-off-by: José Expósito <[email protected]>
> ---
> drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c
> b/drivers/infiniband/hw/qib/qib_user_sdma.c
> index ac11943a5ddb..bf2f30d67949 100644
> --- a/drivers/infiniband/hw/qib/qib_user_sdma.c
> +++ b/drivers/infiniband/hw/qib/qib_user_sdma.c
> @@ -941,7 +941,7 @@ static int qib_user_sdma_queue_pkts(const struct
> qib_devdata *dd,
> &addrlimit) ||
> addrlimit > type_max(typeof(pkt->addrlimit))) {
> ret = -EINVAL;
> - goto free_pbc;
> + goto free_pkt;
> }
> pkt->addrlimit = addrlimit;
>
> --
Thanks for catching my mistake!

Mike

Acked-by: Mike Marciniszyn <[email protected]>
Fixes d39bf40e55e6 ("IB/qib: Protect from buffer overflow in struct qib_user_sdma_pkt fields"):

2021-12-15 00:07:34

by Jason Gunthorpe

Subject: Re: [PATCH] IB/qib: Fix memory leak in qib_user_sdma_queue_pkts

On Wed, Dec 08, 2021 at 06:52:38PM +0100, José Expósito wrote:
> Addresses-Coverity-ID: 1493352 ("Resource leak")
> Signed-off-by: José Expósito <[email protected]>
> Acked-by: Mike Marciniszyn <[email protected]>
> ---
> drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc.

I wrote a commit message and added the missing fixes line, please take
care in future.

Jason